PRIVATE->private and PROTECTED->protected updates in Svc/Fprime* and Svc/Frame* (#3446) (#3660)

Author: m-aleem

Svc/FprimeDeframer/FprimeDeframer.hpp

@@ -27,14 +27,14 @@ class FprimeDeframer final : public FprimeDeframerComponentBase {
     //! Destroy FprimeDeframer object
     ~FprimeDeframer();
 
-  PRIVATE:
+  private:
     // ----------------------------------------------------------------------
     // Handler implementations for user-defined typed input ports
     // ----------------------------------------------------------------------
 
     //! Handler implementation for frame
     //!
-    //! Port to receive framed data. The handler will strip the header and trailer from the frame 
+    //! Port to receive framed data. The handler will strip the header and trailer from the frame
     //! and pass the deframed data to the deframed output port.
     void dataIn_handler(FwIndexType portNum,  //!< The port number
                        Fw::Buffer& data,

Svc/FprimeFramer/FprimeFramer.hpp

@@ -24,7 +24,7 @@ class FprimeFramer final : public FprimeFramerComponentBase {
     //! Destroy FprimeFramer object
     ~FprimeFramer();
 
-  PRIVATE:
+  private:
     // ----------------------------------------------------------------------
     // Handler implementations for typed input ports
     // ----------------------------------------------------------------------

Svc/FprimeRouter/FprimeRouter.hpp

@@ -24,7 +24,7 @@ class FprimeRouter final : public FprimeRouterComponentBase {
     //! Destroy FprimeRouter object
     ~FprimeRouter();
 
-  PRIVATE:
+  private:
     // ----------------------------------------------------------------------
     // Handler implementations for user-defined typed input ports
     // ----------------------------------------------------------------------

Svc/FrameAccumulator/FrameAccumulator.hpp

@@ -15,6 +15,9 @@
 namespace Svc {
 
 class FrameAccumulator final : public FrameAccumulatorComponentBase {
+
+  friend class FrameAccumulatorTester;
+
   public:
     // ----------------------------------------------------------------------
     // Component construction and destruction
@@ -41,7 +44,7 @@ class FrameAccumulator final : public FrameAccumulatorComponentBase {
     void cleanup();
 
 
-  PRIVATE:
+  private:
     // ----------------------------------------------------------------------
     // Handler implementations for user-defined typed input ports
     // ----------------------------------------------------------------------
@@ -58,10 +61,10 @@ class FrameAccumulator final : public FrameAccumulatorComponentBase {
     //! Port receiving ownership back of buffers sent on dataOut
     void dataReturnIn_handler(FwIndexType portNum,  //!< The port number
                                 Fw::Buffer& fwBuffer,  //!< The buffer
-                                const ComCfg::FrameContext& context  //!< The context object  
+                                const ComCfg::FrameContext& context  //!< The context object
                               ) override;
 
-  PRIVATE:
+  private:
     //! \brief process raw buffer
     //! \return raw data buffer
     void processBuffer(Fw::Buffer& buffer);

Svc/FramingProtocol/DeframingProtocol.hpp

@@ -59,7 +59,7 @@ class DeframingProtocol {
                                     U32& needed  /*!< Return needed number of bytes */
     ) = 0;
 
-  PROTECTED:
+  protected:
     DeframingProtocolInterface* m_interface;
 };
 }

Svc/FramingProtocol/FramingProtocol.hpp

@@ -45,7 +45,7 @@ class FramingProtocol {
     //! \param packet_type: type of data supplied for File downlink packets
     virtual void frame(const U8* const data, const U32 size, Fw::ComPacket::ComPacketType packet_type) = 0;
 
-  PROTECTED:
+  protected:
     FramingProtocolInterface* m_interface;
 };
 }