Change struct getters/setters to include _ #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good! I will make the alpha release for this after the alpha release for #754. |
Collaborator
|
The alpha release is started here: https://github.com/nasa/fpp/actions/runs/16475673977. Once this release is integrated into nasa/fprime#3917 and CI passes there, we can merge both PRs (fprime and fpp). |
bocchino
approved these changes
Jul 23, 2025
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks good! Let's wait to merge until the corresponding F Prime PR is done.
thomas-bc
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
_between theget/settoken of a struct's getters/setters and the field name. Fixes: nasa/fprime#3785.This compiles against: nasa/fprime#3917