Merge pull request #25 from nanasess/bcmath-architecture-refactor

refactor(BCMath): major architecture refactoring with DRY principle and unified structure

Author: nanasess

.php-cs-fixer.dist.php

@@ -19,13 +19,8 @@
         'ordered_class_elements' => false,
         'increment_style' => false,
         '@PhpCsFixer:risky' => true,
-        'strict_comparison' => false,
-        'is_null' => false,
         'native_function_invocation' => false,
-        'error_suppression' => true,
         'php_unit_test_case_static_method_calls' => false,
-        'final_internal_class' => false,
-        'php_unit_data_provider_name' => false,
     ])
     ->setFinder($finder)
 ;

lib/bcmath.php

@@ -123,7 +123,7 @@ function bcpowmod($base, $exponent, $modulus, $scale = null): string
      *
      * @param null|int $scale
      */
-    function bcscale($scale = null): int
+    function bcscale($scale = null): ?int
     {
         return BCMath::scale($scale);
     }
@@ -157,11 +157,10 @@ function bcsub($left_operand, $right_operand, $scale = null): string
      * Round down to the nearest integer (PHP 8.4+).
      *
      * @param string $operand
-     * @param null|int $scale optional
      */
-    function bcfloor($operand, $scale = null): string
+    function bcfloor($operand): string
     {
-        return BCMath::floor($operand, $scale);
+        return BCMath::floor($operand);
     }
 }
 
@@ -170,11 +169,10 @@ function bcfloor($operand, $scale = null): string
      * Round up to the nearest integer (PHP 8.4+).
      *
      * @param string $operand
-     * @param null|int $scale optional
      */
-    function bcceil($operand, $scale = null): string
+    function bcceil($operand): string
     {
-        return BCMath::ceil($operand, $scale);
+        return BCMath::ceil($operand);
     }
 }
 

phpstan.neon.dist

@@ -1,10 +1,7 @@
 parameters:
-	level: 6
+	level: max
 	paths:
 		- src
 		- tests
 		- lib
 	ignoreErrors:
-		-
-			message: '#^Static method bcmath_compat\\BCMath::[a-zA-Z_]+\(\) is unused\.$#'
-			identifier: method.unused

rector.php

@@ -3,11 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
-use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
-use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
 use Rector\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector;
-use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector;
 
 return RectorConfig::configure()
     ->withPaths([
@@ -19,11 +15,5 @@
     ->withComposerBased(phpunit: true)
     ->withPreparedSets(typeDeclarations: true, deadCode: true, codeQuality: true)
     ->withSkip([
-        RemoveAlwaysTrueIfConditionRector::class => [
-            __DIR__ . '/tests/BCMathTest.php',
-        ],
         UnwrapFutureCompatibleIfPhpVersionRector::class,
-        RemoveUnusedPrivateMethodParameterRector::class,
-        RemoveUnusedPrivateMethodRector::class,
-        AddMethodCallBasedStrictParamTypeRector::class, // FIXME BCMath::comp() で誤検出されるため暫定的に追加
     ]);