From f91988bd3174cf5a6eaf312cce5ab13246c3065a Mon Sep 17 00:00:00 2001 From: Murisi Tarusenga Date: Fri, 28 Feb 2025 12:15:34 +0200 Subject: [PATCH 1/3] Display payment addresses instead of extended full viewing keys for senders in test vectors. (cherry picked from commit 45d7f2e5c333a147bfc494a72ea652b0a8076244) --- crates/sdk/src/signing.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/crates/sdk/src/signing.rs b/crates/sdk/src/signing.rs index 0c312a0bac0..8acd99ad979 100644 --- a/crates/sdk/src/signing.rs +++ b/crates/sdk/src/signing.rs @@ -18,9 +18,7 @@ use namada_core::arith::checked; use namada_core::collections::{HashMap, HashSet}; use namada_core::ibc::primitives::IntoHostTime; use namada_core::key::*; -use namada_core::masp::{ - AssetData, ExtendedViewingKey, MaspTxId, PaymentAddress, -}; +use namada_core::masp::{AssetData, MaspTxId, PaymentAddress}; use namada_core::tendermint::Time as TmTime; use namada_core::time::DateTimeUtc; use namada_core::token::{Amount, DenominatedAmount}; @@ -837,8 +835,11 @@ async fn make_ledger_token_transfer_endpoints( } if let Some(builder) = builder { for sapling_input in builder.builder.sapling_inputs() { - let vk = ExtendedViewingKey::from(*sapling_input.key()); - output.push(format!("Sender : {}", vk)); + let pa = sapling_input.address().ok_or_else(|| { + Error::Other("unable to load vp code".to_string()) + })?; + let pa = PaymentAddress::from(pa); + output.push(format!("Sender : {}", pa)); make_ledger_amount_asset( tokens, output, From 553540f5505869853e3d6a9d0c6158263da4d4d9 Mon Sep 17 00:00:00 2001 From: Murisi Tarusenga Date: Fri, 28 Feb 2025 12:46:41 +0200 Subject: [PATCH 2/3] Added a changelog entry. (cherry picked from commit b3bcc282691637d708c0be62b2df1e58ad78f5e1) --- .../unreleased/improvements/4436-compress-hw-displays.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .changelog/unreleased/improvements/4436-compress-hw-displays.md diff --git a/.changelog/unreleased/improvements/4436-compress-hw-displays.md b/.changelog/unreleased/improvements/4436-compress-hw-displays.md new file mode 100644 index 00000000000..61714c57497 --- /dev/null +++ b/.changelog/unreleased/improvements/4436-compress-hw-displays.md @@ -0,0 +1,3 @@ +- Display payment addresses instead of extended full + viewing keys on the hardware wallet to save screen space. + ([\#4436](https://github.com/anoma/namada/pull/4436)) \ No newline at end of file From 5633720fd17b1b441ff9178b423035f0f779d0ee Mon Sep 17 00:00:00 2001 From: Murisi Tarusenga Date: Tue, 17 Jun 2025 12:53:43 +0200 Subject: [PATCH 3/3] Update the Ledger app version. (cherry picked from commit 9518da4427a4f20eae6e096a37ba0bc08347d5b4) --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a4a475b4701..e304ee96d7f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,7 +35,7 @@ env: AWS_REGION: us-west-2 NIGHTLY: nightly-2025-03-27 NAMADA_MASP_PARAMS_DIR: /masp/.masp-params - LEDGER_APP_VERSION: "3.0.4" + LEDGER_APP_VERSION: "3.0.7" ROLE: arn:aws:iam::375643557360:role/github-runners-ci-shared SCCACHE_ERROR_LOG: /tmp/sccache_log.txt