Merge branch 'origin/murisi/fix-dry-run-header-and-prover' (#1524)

* origin/murisi/fix-dry-run-header-and-prover:
  Added a changelog entry for this fix.
  Fixed the header of transactions in dry_run.
  Fixed local tx prover dependency regression.

Author: Fraccaman

.changelog/unreleased/bug-fixes/1524-fix-dry-run-header-and-prover.md

@@ -0,0 +1,2 @@
+- This change will enable usage of the Namada SDK to create MASP transactions
+  from non-CLI clients. ([\#1524](https://github.com/anoma/namada/pull/1524))

shared/src/ledger/masp.rs

@@ -1387,20 +1387,13 @@ impl<U: ShieldedUtils> ShieldedContext<U> {
             }
         }
 
-        let prover = if let Ok(params_dir) = env::var(ENV_VAR_MASP_PARAMS_DIR) {
-            let params_dir = PathBuf::from(params_dir);
-            let spend_path = params_dir.join(SPEND_NAME);
-            let convert_path = params_dir.join(CONVERT_NAME);
-            let output_path = params_dir.join(OUTPUT_NAME);
-            LocalTxProver::new(&spend_path, &output_path, &convert_path)
-        } else {
-            LocalTxProver::with_default_location()
-                .expect("unable to load MASP Parameters")
-        };
         // Build and return the constructed transaction
         builder
             .clone()
-            .build(&prover, &FeeRule::non_standard(tx_fee))
+            .build(
+                &self.utils.local_tx_prover(),
+                &FeeRule::non_standard(tx_fee),
+            )
             .map(|(tx, metadata)| {
                 Some((builder.map_builder(WalletMap), tx, metadata, epoch))
             })

shared/src/ledger/queries/shell.rs

@@ -78,10 +78,18 @@ where
     use crate::ledger::storage::write_log::WriteLog;
     use crate::proto::Tx;
     use crate::types::storage::TxIndex;
+    use crate::types::transaction::decrypted::DecryptedTx;
+    use crate::types::transaction::TxType;
 
     let mut gas_meter = BlockGasMeter::default();
     let mut write_log = WriteLog::default();
-    let tx = Tx::try_from(&request.data[..]).into_storage_result()?;
+    let mut tx = Tx::try_from(&request.data[..]).into_storage_result()?;
+    tx.update_header(TxType::Decrypted(DecryptedTx::Decrypted {
+        #[cfg(not(feature = "mainnet"))]
+        // To be able to dry-run testnet faucet withdrawal, pretend
+        // that we got a valid PoW
+        has_valid_pow: true,
+    }));
     let data = protocol::apply_tx(
         tx,
         request.data.len(),

shared/src/ledger/tx.rs

@@ -46,7 +46,6 @@ use crate::types::key::*;
 use crate::types::masp::TransferTarget;
 use crate::types::storage::{Epoch, RESERVED_ADDRESS_PREFIX};
 use crate::types::time::DateTimeUtc;
-use crate::types::transaction::decrypted::DecryptedTx;
 use crate::types::transaction::{pos, InitAccount, TxType, UpdateVp};
 use crate::types::{storage, token};
 use crate::vm;
@@ -353,12 +352,7 @@ pub async fn submit_reveal_pk_aux<
     .await
     .unwrap();
 
-    let mut tx = Tx::new(TxType::Decrypted(DecryptedTx::Decrypted {
-        #[cfg(not(feature = "mainnet"))]
-        // To be able to dry-run testnet faucet withdrawal, pretend 
-        // that we got a valid PoW
-        has_valid_pow: true,
-    }));
+    let mut tx = Tx::new(TxType::Raw);
     tx.header.chain_id = args.chain_id.clone().expect("value should be there");
     tx.header.expiration = args.expiration;
     tx.set_data(Data::new(tx_data));