game_over() set to True when Mario gets a Mushroom in Super Mario World

[folivetti]

Whenever Mario hits a mushroom (and possibly any other item) the game returns True to game_over().

[folivetti]

If you change these lines:

Retro-Learning-Environment/src/games/supported/SuperMarioWorld.cpp

Lines 77 to 84 in 0269da8

	if(time == 0x1){ //shai:comparing to 1 not zero to avoid terminal upon first run
	m_terminal=true;
	}
	else{ // check if the timer has stopped
	if ( (0 < time && time < 300) && (std::adjacent_find( m_lastTime.begin(), m_lastTime.end(), std::not_equal_to<int>() ) == m_lastTime.end()) ){
	m_terminal=true;
	}
	}

To

if (readRam(&system, 0xdda) == 0xff) { m_terminal=true; }

it works

[nadavbh12]

Thanks. Looks like it does fix it.

Though it seems the starting actions are broken. I vaguely remember that the first set of actions doesn't work once you start a game because of the internal saves in Mario.
Moving to save states should solve these issues.

[folivetti]

Though it seems the starting actions are broken.

it seems fine to me. Do you mean the initial inputs are not processed or the actions to start the game are not performed?

[nadavbh12]

Once mario dies, I go to Yoshi's island rather than the beginning of the level.
The starting_actions for the first time you run the game, aren't the same for all subsequent restarts.

[folivetti]

that already happened before. My temp solution was to start a new RLE object

[nadavbh12]

While that may work, it has a larger overhead compared to a simple reset.
Furthermore, you'll need to manually seed the environment after every reset in order to avoid using the same seed every episode.