feat(core): Enable external secrets for projects#26329
Merged
sandra0503 merged 5 commits intomasterfrom Mar 2, 2026
Merged
Conversation
- Hide external secret permission settings in project roles
Bundle ReportChanges will increase total bundle size by 3.5kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
These integrations tests are testing the soon to be deleted endpoints. I think it we can delete these tests already? @ireneea |
Contributor
|
I think we could remove those tests when we actually remove the controller. I don't see anything from the changes here that would cause them to fail 🤔 |
…ed-external-secrets
The user facing term in external secrets vault
…ecrets' of github.com:n8n-io/n8n into ligo-298-fe-expose-releasable-project-scoped-external-secrets
ireneea
approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 9 files
Linked issue analysis
Linked issue: LIGO-298: [FE] Expose releasable project-scoped external secrets
| Status | Acceptance criteria | Notes |
|---|---|---|
| Instance admins should be able to share an external secret store | Adds roleBasedAccess setting and UI gating but no sharing enforcement | |
| ❌ | Project admins and all other users should not be able to create or share external secret stores | No backend permission checks to prevent create/share actions |
Architecture diagram
sequenceDiagram
participant UI as Frontend (ProjectRoleView)
participant SS as Frontend Settings Store
participant API as Backend API
participant ESM as External Secrets Module
participant ESC as External Secrets Config
Note over ESC: Backend Initialization
ESC->>ESC: CHANGED: externalSecretsForProjects = true (default)
ESC->>ESC: NEW: externalSecretsRoleBasedAccess = false (default)
Note over UI, ESM: Runtime Settings Fetch
UI->>API: Fetch Frontend Settings
API->>ESM: getFrontendSettings()
ESM->>ESC: Read feature flags
ESC-->>ESM: forProjects, roleBasedAccess, multipleConnections
ESM-->>API: { "external-secrets": { forProjects, roleBasedAccess, ... } }
API-->>UI: JSON Settings
UI->>SS: Commit settings to store
Note over UI: Project Roles Management
UI->>SS: Request moduleSettings['external-secrets']
SS-->>UI: Return config flags
alt NEW: roleBasedAccess == true
UI->>UI: Render 'externalSecretsProvider' and 'externalSecret' scopes
Note right of UI: UI Labels CHANGED: "Secrets Vaults" (formerly "Stores")
else roleBasedAccess == false (Default)
UI->>UI: CHANGED: Filter out secret-related permission scopes
end
opt CHANGED: Project Admin UI
UI->>UI: Terminology updated from "Secrets Store" to "Secrets Vault"
Note right of UI: Affects empty states and tooltips
end
Merged
Tuukkaa
pushed a commit
that referenced
this pull request
Mar 2, 2026
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Closes LIGO-298
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)