fix(editor): Always show auth mode dropdown in credential modal#26280
Merged
fix(editor): Always show auth mode dropdown in credential modal#26280
Conversation
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 7 files
Linked issue analysis
Linked issue: NODE-4511: Always show dropdown for auth mode selection
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Always show dropdown for auth mode selection (use dropdown even when only 2 options) | Removed switch link and render dropdown when options.length >= 2 |
| ✅ | Preserve dropdown behavior for 3+ auth options | Tests still assert and exercise dropdown for 3+ options |
| ✅ | Update unit tests to expect dropdown instead of switch link | Unit tests updated to open dropdown and click menu items |
| ✅ | Update e2e Playwright tests/helpers to use dropdown selection instead of switch link | Playwright test now selects via dropdown and helper removed switch link getter |
Architecture diagram
sequenceDiagram
* participant User
* participant CC as CredentialConfig (Vue)
* participant CMS as CredentialModeSelector (Vue)
* participant Stores as Pinia Stores (Credentials/NDV)
Note over User,Stores: Credential Modal Initialization (New or Edit)
CC->>Stores: Check permissions & mode
Stores-->>CC: canWrite: true, mode: 'new' | 'edit'
CC->>CC: CHANGED: Evaluate visibility (canWrite only)
opt canWrite is true
CC->>CMS: Render with CredentialType
CMS->>Stores: Get node configuration & auth options
Stores-->>CMS: List of auth modes (e.g., OAuth2, Header Auth)
CMS->>CMS: CHANGED: Calculate dropdown visibility (options >= 2)
alt Options >= 2
CMS->>User: Display Dropdown Trigger
else Single Option
CMS->>User: Hide Selector
end
end
Note over User,CMS: User Interaction
User->>CMS: Click Dropdown Trigger
CMS->>User: Show Dropdown Menu Items
User->>CMS: Select Auth Mode
CMS->>CC: CHANGED: Emit update:authType(selectedMode)
CC->>Stores: Update node parameters / credential state
CC->>User: Refresh fields for selected auth mode
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 1.82kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
|
This comment has been minimized.
This comment has been minimized.
yehorkardash
approved these changes
Mar 3, 2026
Merged
Matsuuu
pushed a commit
that referenced
this pull request
Mar 4, 2026
Matsuuu
pushed a commit
that referenced
this pull request
Mar 4, 2026
Merged
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Even when there are only 2 options, show the dropdown instead of a link.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4511/always-show-dropdown-for-auth-mode-selection
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)