fix(core): Don't show setup in demo mode

[yehorkardash]

Summary

This PR fixes issue when sometimes in demo mode n8n returned showSetupOnFirstLoad: true

Testing:

• copy hooks directory locally from here
• Set those envs

EXTERNAL_HOOK_FILES=path/to/hooks/directory
N8N_PREVIEW_MODE=true
NODE_ENV=production
N8N_USER_MANAGEMENT_JWT_SECRET=secret

• open http://localhost:5678/workflows/demo

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[Matsuuu]

I'd also prefer is someone more familiar with the codebase co-reviewed this with me 👍🏼 🙂

[cubic-dev-ai]

No issues found across 2 files

Architecture diagram

sequenceDiagram
    participant Client as Frontend UI
    participant FS as FrontendService
    participant Env as Environment (N8N_PREVIEW_MODE)
    participant OS as OwnershipService

    Note over Client, OS: Request for application configuration
    Client->>FS: getPublicSettings()
    FS->>FS: getSettings()
    
    FS->>Env: Check process.env.N8N_PREVIEW_MODE
    
    FS->>FS: NEW: getShowSetupOnFirstLoad()
    
    alt NEW: Preview/Demo Mode is Enabled (true)
        Note right of FS: Bypass DB check to allow demo access
        FS->>FS: Set showSetupOnFirstLoad = false
    else Standard Mode
        FS->>OS: hasInstanceOwner()
        OS-->>FS: return boolean
        FS->>FS: CHANGED: Set showSetupOnFirstLoad = !hasInstanceOwner
    end

    FS-->>FS: Update this.settings.userManagement
    FS-->>Client: Return PublicFrontendSettings (showSetupOnFirstLoad)

    Note over Client: If false, user bypasses setup<br/>and enters the app directly.

Loading

[MiloradFilipovic]

Looks good, thanks for addressing this 🙌

[n8n-assistant]

Got released with [email protected]

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!