fix(editor): Resolve credential modal expressions without workflow co…#26191
Merged
sandra0503 merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
…ntext When the credentials modal is opened from the NDV (which sets an active node), expressions like $secrets were incorrectly resolved using the workflow context instead of resolveWithoutWorkflow. This happened because the condition only checked for the absence of an active node, which is never true when the modal is opened from the NDV. Add an explicit isCredentialsModalOpen() check so credential expressions always use resolveWithoutWorkflow, regardless of whether an active node exists.
Bundle ReportChanges will increase total bundle size by 88 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
geemanjs
approved these changes
Feb 24, 2026
| } else if (!ndvStore.activeNode && toValue(targetNodeParameterContext) === undefined) { | ||
| } else if ( | ||
| isCredentialsModalOpen() || | ||
| (!ndvStore.activeNode && toValue(targetNodeParameterContext) === undefined) |
Contributor
There was a problem hiding this comment.
So the second condition here describes the case of isNodeDetailsViewOpen?
sandra0503
deleted the
ligo-241-fe-bug-bash-secrets-that-are-resolved-show-as-red
branch
Merged
Tuukkaa
pushed a commit
that referenced
this pull request
Mar 2, 2026
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntext
Summary
When the credentials modal is opened from the NDV (which sets an active node), expressions like $secrets were incorrectly resolved using the workflow context instead of resolveWithoutWorkflow. This happened because the condition only checked for the absence of an active node, which is never true when the modal is opened from the NDV.
Add an explicit isCredentialsModalOpen() check so credential expressions always use resolveWithoutWorkflow, regardless of whether an active node exists.
Related Linear tickets, Github issues, and Community forum posts
Fixes LIGO-241
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)