fix: Enable external secrets multi-connection to vault #26189
fix: Enable external secrets multi-connection to vault #26189
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 2.35kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
|
| const isFeatureEnabled = computed(() => | ||
| envFeatureFlag.check.value('EXTERNAL_SECRETS_FOR_PROJECTS'), | ||
| const isFeatureEnabled = computed( | ||
| () => settingsStore.moduleSettings['external-secrets']?.forProjects ?? false, |
There was a problem hiding this comment.
Do you know how I would change these moduleSettings on a cloud instance once I ssh into it?
Asking since I know how to do this with an env var but not with moduleSettings.
There was a problem hiding this comment.
Ah nevermind, I see you're wiring up the env vars with module settings in packages/cli/src/modules/external-secrets.ee/external-secrets.module.ts -> settings()
There was a problem hiding this comment.
Module settings are run time logic based so you can't directly affect their values.
In this case the value is based on our backend logic which is
- if no env var -> return
true - if there is an env var -> use the env var value
So you could still set the env var to inderectly affect the module setting value
konstantintieber
left a comment
There was a problem hiding this comment.
Learned something new about our backend today. Thx for migrating from pure env vars to moduleSettings!
Really handy pattern.
|
Got released with |
Summary
Replaces
useEnvFeatureFlagchecks (EXTERNAL_SECRETS_FOR_PROJECTS,EXTERNAL_SECRETS_MULTIPLE_CONNECTIONS) with backend-driven module settings exposed viasettingsStore.moduleSettings['external-secrets'].How to test
env vars
N8N_ENV_FEAT_EXTERNAL_SECRETS_FOR_PROJECTSN8N_ENV_FEAT_EXTERNAL_SECRETS_MULTIPLE_CONNECTIONSWithout env vars
With
N8N_ENV_FEAT_EXTERNAL_SECRETS_MULTIPLE_CONNECTIONSset tofalseN8N_ENV_FEAT_EXTERNAL_SECRETS_MULTIPLE_CONNECTIONSset tofalseWith
N8N_ENV_FEAT_EXTERNAL_SECRETS_FOR_PROJECTSset totrueN8N_ENV_FEAT_EXTERNAL_SECRETS_FOR_PROJECTSset tofalseRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/LIGO-280
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)