fix(core): Increase timeout for workflow execution tests#26150
Merged
shortstacked merged 2 commits intomasterfrom Feb 27, 2026
Merged
fix(core): Increase timeout for workflow execution tests#26150shortstacked merged 2 commits intomasterfrom
shortstacked merged 2 commits intomasterfrom
Conversation
The retry_and_continue_on_error test executes ~46 Code node sandboxes with retries, which can exceed the default 5s Jest timeout on slow CI runners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The "creates new node project with custom template" test involves filesystem operations and template scaffolding that can exceed the default 5s timeout on slow CI runners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Jest as Jest Runner
participant Test as Workflow Test File
participant Engine as WorkflowExecute (Core)
participant Node as Code Node Execution
participant Sandbox as JavaScriptSandbox (VM)
Note over Jest,Sandbox: High-load Workflow Execution Test (retry_and_continue_on_error)
Jest->>Test: CHANGED: Execute test block with 15s timeout (was 5s)
Test->>Engine: execute(workflowJSON)
loop For each Node in Workflow (31 total)
Engine->>Node: run()
Note over Node,Sandbox: Cumulative resource overhead
Node->>Sandbox: NEW: Initialize VM context
Node->>Sandbox: Execute JS code
Sandbox-->>Node: Execution result
alt Node fails AND retryOnFail is true
Node->>Node: Wait (waitBetweenTries: 10ms)
Node->>Sandbox: NEW: Re-initialize VM & re-run
Sandbox-->>Node: Execution result
end
Node-->>Engine: nodeOutput
end
Note over Jest: Jest monitors elapsed time
alt Total Time < 15s
Engine-->>Test: executionResult
Test-->>Jest: Test Passed
else Total Time > 15s (Old behavior on slow CI)
Jest->>Test: Terminate (Timeout Error)
end
scdekov
approved these changes
Feb 27, 2026
Merged
Tuukkaa
pushed a commit
that referenced
this pull request
Mar 2, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run test workflowstests from the default 5s to 15sretry_and_continue_on_errortest executes ~46 Code node sandbox instances with retries, which intermittently exceeds the 5s default on slow CI runnersRoot cause
The workflow test JSON exercises 31 nodes (15 Reset Count + 16 Retry/Continue Code nodes) with
retryOnFail: trueandwaitBetweenTries: 10ms. Each Code node creates aJavaScriptSandboxVM context. The cumulative sandbox creation + execution time is ~3.5s locally (cold) and can exceed 5s on shared CI runners under load.Test plan
🤖 Generated with Claude Code