feat(core): Expand workflow-sdk test fixtures from 500 to 2000 workflows and fix codegen bugs (#26041)

Co-authored-by: Claude Opus 4.6 <[email protected]>

Author: 2 people

packages/@n8n/workflow-sdk/scripts/fetch-test-workflows.ts

@@ -98,7 +98,7 @@ async function main() {
 	const allWorkflowIds: number[] = [];
 
 	// Fetch multiple pages to get enough workflow IDs
-	for (let page = 1; page <= 10; page++) {
+	for (let page = 1; page <= 20; page++) {
 		const results = await searchWorkflows(page, 100);
 		if (results.length === 0) break;
 
@@ -112,15 +112,15 @@ async function main() {
 		);
 
 		// Stop if we have enough candidates
-		if (allWorkflowIds.length >= 200) break;
+		if (allWorkflowIds.length >= 2000) break;
 	}
 
 	console.log(`\nFound ${allWorkflowIds.length} new workflow candidates\n`);
 	console.log('Fetching workflows (only published)...\n');
 
 	const results: { id: number; name: string; success: boolean }[] = [];
 	let publishedCount = 0;
-	const TARGET_COUNT = 100;
+	const TARGET_COUNT = 1000;
 
 	for (const id of allWorkflowIds) {
 		if (publishedCount >= TARGET_COUNT) {

packages/@n8n/workflow-sdk/src/__tests__/fixtures-zip.ts

@@ -58,7 +58,10 @@ export function needsExtraction(): boolean {
 }
 
 /**
- * Extract workflows from zip file
+ * Extract workflows from zip file.
+ * Skips manifest.json so the committed (git-tracked) manifest is preserved.
+ * The zip may contain a stale manifest; the committed one is the source of truth
+ * for expectedWarnings and skip flags.
  */
 export function extractWorkflowsFromZip(): void {
 	if (!fs.existsSync(ZIP_PATH)) {
@@ -71,7 +74,12 @@ export function extractWorkflowsFromZip(): void {
 	}
 
 	const zip = new AdmZip(ZIP_PATH);
-	zip.extractAllTo(REAL_WORKFLOWS_DIR, true); // overwrite existing
+	for (const entry of zip.getEntries()) {
+		if (entry.isDirectory) continue;
+		// Skip manifest.json — the committed version is the source of truth
+		if (entry.entryName === 'manifest.json') continue;
+		zip.extractEntryTo(entry, REAL_WORKFLOWS_DIR, false, true);
+	}
 }
 
 /**

packages/@n8n/workflow-sdk/src/ast-interpreter/interpreter.ts

@@ -35,10 +35,13 @@ export type SDKFunctions = Record<string, (...args: any[]) => unknown>;
  * Walks the AST and evaluates SDK patterns.
  */
 class SDKInterpreter {
+	private static readonly MAX_EVAL_DEPTH = 500;
+
 	private sdkFunctions: Map<string, (...args: unknown[]) => unknown>;
 	private variables: Map<string, unknown>;
 	private renamedVariables: Map<string, string> = new Map();
 	private sourceCode: string;
+	private evalDepth = 0;
 
 	constructor(sdkFunctions: SDKFunctions, sourceCode: string) {
 		this.sdkFunctions = new Map(Object.entries(sdkFunctions));
@@ -136,6 +139,23 @@ class SDKInterpreter {
 	private evaluate(node: ESTree.Expression | ESTree.SpreadElement | null): unknown {
 		if (node === null) return undefined;
 
+		if (this.evalDepth >= SDKInterpreter.MAX_EVAL_DEPTH) {
+			throw new InterpreterError(
+				'Expression nesting too deep (possible cycle in method chain)',
+				node.loc ?? undefined,
+				this.sourceCode,
+			);
+		}
+
+		this.evalDepth++;
+		try {
+			return this.evaluateNode(node);
+		} finally {
+			this.evalDepth--;
+		}
+	}
+
+	private evaluateNode(node: ESTree.Expression | ESTree.SpreadElement): unknown {
 		validateNodeType(node, this.sourceCode);
 
 		switch (node.type) {