Skip to content

Commit 610b905

Browse files
not-an-aardvarkmysticatea
authored andcommitted
Fix: no-deprecated-api crash on undeclared assignment (fixes #55) (#56)
1 parent 382886e commit 610b905

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

lib/rules/no-deprecated-api.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,10 @@ module.exports = function(context) {
246246
break
247247

248248
case "Identifier":
249-
checkVariable(
250-
findVariable(node, globalScope),
251-
path,
252-
infoMap
253-
)
249+
var variable = findVariable(node, globalScope)
250+
if (variable != null) {
251+
checkVariable(variable, path, infoMap)
252+
}
254253
break
255254

256255
case "ObjectPattern":

tests/lib/rules/no-deprecated-api.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,12 @@ ruleTester.run("no-deprecated-api", rule, {
8686
code: "import domain from 'domain';",
8787
parserOptions: {sourceType: "module"},
8888
},
89+
90+
// https://github.com/mysticatea/eslint-plugin-node/issues/55
91+
{
92+
code: "undefinedVar = require('fs')",
93+
env: {node: true},
94+
},
8995
],
9096
invalid: [
9197
//----------------------------------------------------------------------

0 commit comments

Comments
 (0)