Fix: third-party does not hide core modules

Author: mysticatea

docs/rules/no-deprecated-api.md

@@ -93,8 +93,7 @@ This rule has 2 options.
     "rules": {
         "node/no-deprecated-api": ["error", {
             "ignoreModuleItems": [],
-            "ignoreGlobalItems": [],
-            "ignoreIndirectDependencies": false
+            "ignoreGlobalItems": []
         }]
     }
 }
@@ -185,12 +184,6 @@ Examples of :+1: **correct** code for the `{"ignoreGlobalItems": ["new Buffer()"
 const data = new Buffer(10) // OK since it's in ignoreGlobalItems.
 ```
 
-### ignoreIndirectDependencies
-
-If `ignoreIndirectDependencies: true`, this rule ignores deprecated APIs if your module depends on third-party modules which have the same name as core modules indirectly. Default is `false`.
-
-If your module depends on such third-party modules directly (explicitly), this rule always ignores deprecated APIs of those.
-
 ## Known Limitations
 
 This rule cannot report the following cases:

lib/rules/no-deprecated-api.js

@@ -10,11 +10,8 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const dirname = require("path").dirname
 const assign = require("object-assign")
-const resolve = require("resolve").sync
 const deprecatedApis = require("../util/deprecated-apis")
-const getPackageJson = require("../util/get-package-json")
 const getValueIfString = require("../util/get-value-if-string")
 
 //------------------------------------------------------------------------------
@@ -195,45 +192,8 @@ function create(context) {
     const options = context.options[0] || {}
     const ignoredModuleItems = options.ignoreModuleItems || []
     const ignoredGlobalItems = options.ignoreGlobalItems || []
-    const ignoreIndirectDependencies = Boolean(options.ignoreIndirectDependencies)
     let globalScope = null
 
-    /**
-     * Checks whether the third party module of the given module ID exists or
-     * not.
-     *
-     * @param {string} moduleId - The module ID to check.
-     * @returns {boolean} `true` if the third party module existed.
-     */
-    function isThirdPartyInstalled(moduleId) {
-        const fileName = context.getFilename()
-        if (fileName !== "<input>") {
-            if (ignoreIndirectDependencies) {
-                const basedir = dirname(fileName)
-                try {
-                    return resolve(moduleId, {basedir}) !== moduleId
-                }
-                catch (_err) {
-                    // ignore
-                }
-            }
-            else {
-                const packageInfo = getPackageJson(fileName)
-                const deps = packageInfo && packageInfo.dependencies
-                const devDeps = packageInfo && packageInfo.devDependencies
-
-                /*eslint-disable no-prototype-builtins */
-                return Boolean(
-                    (deps && deps.hasOwnProperty(moduleId)) ||
-                    (devDeps && devDeps.hasOwnProperty(moduleId))
-                )
-                /*eslint-enable */
-            }
-        }
-
-        return false
-    }
-
     /**
      * Reports a use of a deprecated API.
      *
@@ -512,10 +472,7 @@ function create(context) {
 
             if (node.type === "CallExpression" && node.callee === id) {
                 const key = getValueIfString(node.arguments[0])
-                if (key != null &&
-                    hasOwnProperty.call(infoMap, key) &&
-                    !isThirdPartyInstalled(key)
-                ) {
+                if (key != null && hasOwnProperty.call(infoMap, key)) {
                     const moduleInfo = infoMap[key]
                     if (moduleInfo.$deprecated) {
                         reportModule(node, key, moduleInfo)
@@ -538,9 +495,7 @@ function create(context) {
 
         for (const node of programNode.body.filter(isImportDeclaration)) {
             const key = node.source.value
-            if (hasOwnProperty.call(infoMap, key) &&
-                !isThirdPartyInstalled(key)
-            ) {
+            if (hasOwnProperty.call(infoMap, key)) {
                 const moduleInfo = infoMap[key]
                 if (moduleInfo.$deprecated) {
                     reportModule(node, key, moduleInfo)
@@ -611,9 +566,9 @@ module.exports = {
                         additionalItems: false,
                         uniqueItems: true,
                     },
-                    ignoreIndirectDependencies: { //
-                        type: "boolean",
-                    },
+
+                    // Deprecated since v4.2.0
+                    ignoreIndirectDependencies: {type: "boolean"},
                 },
                 additionalProperties: false,
             },

tests/lib/rules/no-deprecated-api.js

@@ -10,27 +10,9 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const path = require("path")
 const rule = require("../../../lib/rules/no-deprecated-api")
 const RuleTester = require("eslint/lib/testers/rule-tester")
 
-//------------------------------------------------------------------------------
-// Helpers
-//------------------------------------------------------------------------------
-
-const THIRD_PERTY = path.resolve(
-    __dirname,
-    "../../fixtures/no-deprecated-api/thirdparty/test.js"
-)
-const NO_THIRD_PERTY = path.resolve(
-    __dirname,
-    "../../fixtures/no-deprecated-api/no-thirdparty/test.js"
-)
-const INDIRECT_THIRD_PERTY = path.resolve(
-    __dirname,
-    "../../fixtures/no-deprecated-api/indirect-thirdparty/test.js"
-)
-
 //------------------------------------------------------------------------------
 // Tests
 //------------------------------------------------------------------------------
@@ -83,15 +65,13 @@ ruleTester.run("no-deprecated-api", rule, {
             env: {node: true},
         },
 
-        // there are third parties.
+        // use third parties.
         {
-            filename: THIRD_PERTY,
-            code: "require('domain');",
+            code: "require('domain/');",
             env: {node: true},
         },
         {
-            filename: THIRD_PERTY,
-            code: "import domain from 'domain';",
+            code: "import domain from 'domain/';",
             parserOptions: {sourceType: "module"},
         },
 
@@ -168,8 +148,7 @@ ruleTester.run("no-deprecated-api", rule, {
 
         // https://github.com/mysticatea/eslint-plugin-node/issues/65
         {
-            filename: INDIRECT_THIRD_PERTY,
-            code: "require(\"domain\")",
+            code: "require(\"domain/\")",
             env: {node: true},
             options: [{ignoreIndirectDependencies: true}],
         },
@@ -458,21 +437,6 @@ ruleTester.run("no-deprecated-api", rule, {
             errors: ["'util._extend' was deprecated since v6. Use 'Object.assign()' instead."],
         },
 
-        // https://github.com/mysticatea/eslint-plugin-node/issues/65
-        {
-            filename: INDIRECT_THIRD_PERTY,
-            code: "require(\"domain\")",
-            env: {node: true},
-            errors: ["'domain' module was deprecated since v4."],
-        },
-        {
-            filename: INDIRECT_THIRD_PERTY,
-            code: "require(\"domain\")",
-            env: {node: true},
-            options: [{ignoreIndirectDependencies: false}],
-            errors: ["'domain' module was deprecated since v4."],
-        },
-
         // ES2015 Modules
         {
             code: "import b from 'buffer'; new b.Buffer()",
@@ -587,15 +551,12 @@ ruleTester.run("no-deprecated-api", rule, {
             errors: ["'process.env.NODE_REPL_HISTORY_FILE' was deprecated since v4. Use 'NODE_REPL_HISTORY' instead."],
         },
 
-        // there are no third parties.
         {
-            filename: NO_THIRD_PERTY,
             code: "require('domain');",
             env: {node: true},
             errors: ["'domain' module was deprecated since v4."],
         },
         {
-            filename: NO_THIRD_PERTY,
             code: "import domain from 'domain';",
             parserOptions: {sourceType: "module"},
             errors: ["'domain' module was deprecated since v4."],