fix

Author: theofidry

README.md

@@ -27,6 +27,7 @@ DeepCopy helps you create deep copies (clones) of your objects. It is designed t
         1. [`DoctrineProxyFilter`](#doctrineproxyfilter-filter)
         1. [`ReplaceFilter`](#replacefilter-type-filter)
         1. [`ShallowCopyFilter`](#doctrinecollectionfilter-type-filter)
+1. [Edge cases](#edge-cases)
 1. [Contributing](#contributing)
     1. [Tests](#tests)
 
@@ -297,6 +298,15 @@ $myServiceWithMocks = new MyService(m::mock(MyDependency1::class), m::mock(MyDep
 ```
 
 
+## Edge cases
+
+The following structures cannot be deep-copied with PHP Reflection. As a result they are shallow cloned and filters are
+not applied. There is two ways for you to handle them:
+
+- Implement your own `__clone()` method
+- Use a filter with a type matcher
+
+
 ## Contributing
 
 DeepCopy is distributed under the MIT license.

fixtures/f007/FooDateInterval.php

@@ -6,7 +6,10 @@
 
 class FooDateInterval extends DateInterval
 {
+    public $cloned = false;
+
     public function __clone()
     {
+        $this->cloned = true;
     }
 }

fixtures/f007/FooDateTimeZone.php

@@ -6,7 +6,10 @@
 
 class FooDateTimeZone extends DateTimeZone
 {
+    public $cloned = false;
+
     public function __clone()
     {
+        $this->cloned = true;
     }
 }

src/DeepCopy/DeepCopy.php

@@ -187,11 +187,9 @@ private function copyObject($object)
             return $newObject;
         }
 
-        $newObjectClass = get_class($newObject);
-
         if ($newObject instanceof DateTimeInterface
-            || $newObjectClass === DateTimeZone::class
-            || $newObjectClass === DateInterval::class
+            || $newObject instanceof DateTimeZone
+            || $newObject instanceof DateInterval
         ) {
             return $newObject;
         }
@@ -231,7 +229,6 @@ function ($object) {
             }
         }
 
-        // No filter has been applied: simply copy the value
         $property->setAccessible(true);
         $propertyValue = $property->getValue($object);
 

tests/DeepCopyTest/DeepCopyTest.php

@@ -158,29 +158,41 @@ public function test_it_can_copy_an_object_with_a_date_object_property()
     /**
      * @ticket https://github.com/myclabs/DeepCopy/pull/70
      */
-    public function test_it_does_not_skip_the_copy_for_userland_datetimezone()
+    public function test_it_skips_the_copy_for_userland_datetimezone()
     {
+        $deepCopy = new DeepCopy();
+        $deepCopy->addFilter(
+            new SetNullFilter(),
+            new PropertyNameMatcher('cloned')
+        );
+
         $object = new stdClass();
 
         $object->dtz = new f007\FooDateTimeZone('UTC');
 
-        $copy = deep_copy($object);
+        $copy = $deepCopy->copy($object);
 
-        $this->assertEqualButNotSame($object->dtz, $copy->dtz);
+        $this->assertTrue($copy->dtz->cloned);
     }
 
     /**
      * @ticket https://github.com/myclabs/DeepCopy/pull/76
      */
-    public function test_it_does_not_skip_the_copy_for_userland_dateinterval()
+    public function test_it_skips_the_copy_for_userland_dateinterval()
     {
+        $deepCopy = new DeepCopy();
+        $deepCopy->addFilter(
+            new SetNullFilter(),
+            new PropertyNameMatcher('cloned')
+        );
+
         $object = new stdClass();
 
         $object->di = new f007\FooDateInterval('P2D');
 
-        $copy = deep_copy($object);
+        $copy = $deepCopy->copy($object);
 
-        $this->assertEqualButNotSame($object->di, $copy->di);
+        $this->assertTrue($copy->di->cloned);
     }
 
     public function test_it_copies_the_private_properties_of_the_parent_class()