Merged
Conversation
Closed
4 tasks
mxinden
approved these changes
Jun 24, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Confirmed to fix rust-libp2p as well.
Thank you very much @ackintosh for both debugging and providing the full patch!
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the CI workflow on Linux fails.
https://github.com/ackintosh/if-watch/runs/7024984543?check_suite_focus=true
From what I've seen, it is due to incompatibility in
netlink-proto v0.9.3, which is a dependency ofrtnetlink v0.9.ErrorKindis removed innetlink-proto v0.9.3butrtnetlink v0.9is still using it.The issue above can be solved by updating rtnetlink from v0.9 to v0.10.
Release note on
netlink: https://github.com/little-dude/netlink/releases/tag/20220623