Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented Jun 30, 2024

Closes #1244

@github-actions
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@support_gonb

(this requires nodejs, see more at Developing Jupytext)

Base automatically changed from disable_pyupgrade to main June 30, 2024 15:07
@mwouts mwouts force-pushed the support_gonb branch 2 times, most recently from c933c88 to 37f6d3f Compare July 1, 2024 21:36
@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (508f4ea) to head (58383d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1250   +/-   ##
=======================================
  Coverage   97.02%   97.03%           
=======================================
  Files          29       29           
  Lines        4468     4479   +11     
=======================================
+ Hits         4335     4346   +11     
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


if self.default_language == "go" and self.language is None:
lines = [
re.sub(r"^([/\s]*)(//\s*gonb:%%)", r"\1%%", line) for line in lines
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to escape the %% commands in Markdown cells too, that's why we might find multiple levels of comments.

@mwouts mwouts marked this pull request as ready for review July 6, 2024 21:44
@mwouts mwouts merged commit ce74c51 into main Jul 9, 2024
@mwouts mwouts deleted the support_gonb branch July 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: support gonb

2 participants