add toText tests and update private fields

Author: danielailie

src/wallet/validatorPem.spec.ts

@@ -57,4 +57,15 @@ describe("test ValidatorPEMs", () => {
         );
         assert.equal(entry.secretKey.hex(), "3034b1d58628a842984da0c70da0b5a251ebb2aebf51afc5b586e2839b5e5263");
     });
+
+    it("should convert to text", async function () {
+        let text = fs.readFileSync(path.join(walletsPath, "validatorKey00.pem"), "utf-8").trim();
+        const entry = await ValidatorPEM.fromTextAll(text);
+        assert.deepEqual(entry[0].toText(), text);
+
+        text = fs.readFileSync(path.join(walletsPath, "multipleValidatorKeys.pem"), "utf-8").trim();
+        const entries = await ValidatorPEM.fromTextAll(text);
+        const actualText = entries.map((entry) => entry.toText()).join("\n");
+        assert.deepEqual(actualText, text);
+    });
 });

src/wallet/validatorPem.ts

@@ -4,8 +4,8 @@ import { PemEntry } from "../wallet/pemEntry";
 import { BLS, ValidatorSecretKey } from "../wallet/validatorKeys";
 
 export class ValidatorPEM {
-    label: string;
-    secretKey: ValidatorSecretKey;
+    readonly label: string;
+    readonly secretKey: ValidatorSecretKey;
 
     constructor(label: string, secretKey: ValidatorSecretKey) {
         this.label = label;
@@ -30,8 +30,8 @@ export class ValidatorPEM {
         const entries = PemEntry.fromTextAll(text);
         const resultItems: ValidatorPEM[] = [];
 
+        await BLS.initIfNecessary();
         for (const entry of entries) {
-            await BLS.initIfNecessary();
             const secretKey = new ValidatorSecretKey(entry.message);
             const item = new ValidatorPEM(entry.label, secretKey);
             resultItems.push(item);

src/wallet/validatorSigner.ts

@@ -6,15 +6,19 @@ import { ValidatorPEM } from "./validatorPem";
  * Validator signer (BLS signer)
  */
 export class ValidatorSigner {
-    private secretKey: ValidatorSecretKey;
+    private readonly secretKey: ValidatorSecretKey;
 
     constructor(secretKey: ValidatorSecretKey) {
         this.secretKey = secretKey;
     }
     /**
      * Signs a message.
      */
-    async signUsingPem(pemText: string, pemIndex: number = 0, signable: Buffer | Uint8Array): Promise<Uint8Array> {
+    static async signUsingPem(
+        pemText: string,
+        pemIndex: number = 0,
+        signable: Buffer | Uint8Array,
+    ): Promise<Uint8Array> {
         await BLS.initIfNecessary();
 
         try {