fix: make getPeerId resolve the last id #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
getPeerIdreturns the first PeerId in the multiaddr. For most addresses this is fine. However, if a node is using a relay as an entrypoint, such as nodes running AutoRelay, getPeerId returns the id of the relay and not the destination peer.For example the multiaddr,
/ip4/0.0.0.0/tcp/8080/p2p/QmRelay/p2p-circuit/p2p/QmTarget, indicates that the target peerQmTargetis dialable over the relay peerQmRelay. RunninggetPeerIdresolvesQmRelayinstead ofQmTarget. The last peer id in the address should always be the target peer.