-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[infra] Stabilise tests by removing babel and plugins from vitest #18341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f0e24f3
fix datagrid test
JCQuintas e7c6d48
stable config
JCQuintas cecd5af
631c369
74f2487
553ef7b
double connect timeout
JCQuintas 46132fa
versions
JCQuintas b0aa5c4
catalog
JCQuintas 9b8ce18
disable lib
JCQuintas da20d2c
fix files
JCQuintas 6d237b7
Merge commit 'aea0bd2aadc915733d4d94e11333b58e68732c47' into fix-data…
JCQuintas 0050250
try no forwardref babel transform
JCQuintas 81649aa
fix issues
JCQuintas d811c87
fix
JCQuintas bfe78e1
Revert "disable lib"
JCQuintas e445f24
Revert "stable config"
JCQuintas aa747e2
Revert "fix datagrid test"
JCQuintas 02a77d8
3516bcd
aa67efb
e3ef3ab
96244ca
207aa51
Merge branch 'master' into fix-datagrid-test
JCQuintas 5dd8837
21d9a80
078f4bb
5b68314
Update vitest.shared.mts
JCQuintas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,24 +36,9 @@ export const alias = [ | |
| ]; | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [ | ||
| react({ | ||
| babel: { | ||
| plugins: [ | ||
| [ | ||
| '@mui/internal-babel-plugin-display-name', | ||
| { | ||
| allowedCallees: { | ||
| '@mui/x-internals/forwardRef': ['forwardRef'], | ||
| }, | ||
| }, | ||
| ], | ||
| ], | ||
| babelrc: false, | ||
| configFile: false, | ||
| }, | ||
| }), | ||
| ], | ||
| // If enabling babel plugins, ensure the tests in CI are stable | ||
| // https://github.com/mui/mui-x/pull/18341 | ||
| plugins: [react()], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this was the culprit for almost 100% flaky tests, I'm all in with the compromise. 👍 |
||
| // We seem to need both this and the `env` property below to make it work. | ||
| define: { | ||
| 'process.env.NODE_ENV': '"test"', | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.