Skip to content

[TreeView] Support experimental features from plugin's dependencies #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[TreeView] Support experimental features from plugin's dependencies #13632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/x-tree-view/src/internals/models/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ export type TreeViewPluginSignature<
>;
}
: {};
experimentalFeatures: T['experimentalFeatures'];
experimentalFeatures: T extends { experimentalFeatures: string }
? { [key in T['experimentalFeatures']]?: boolean }
: {};
dependencies: T extends { dependencies: Array<any> } ? T['dependencies'] : [];
optionalDependencies: T extends { optionalDependencies: Array<any> }
? T['optionalDependencies']
Expand Down
3 changes: 2 additions & 1 deletion packages/x-tree-view/src/internals/models/treeView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ export type TreeViewPublicAPI<

export type TreeViewExperimentalFeatures<
TSignatures extends readonly TreeViewAnyPluginSignature[],
> = { [key in MergeSignaturesProperty<TSignatures, 'experimentalFeatures'>]?: boolean };
TOptionalSignatures extends readonly TreeViewAnyPluginSignature[] = [],
> = MergeSignaturesProperty<[...TSignatures, ...TOptionalSignatures], 'experimentalFeatures'>;
Copy link
Member Author

@flaviendelangle flaviendelangle Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added support for the optional plugins even if we never use it for now, just to be consistent with the instance and params

2 changes: 1 addition & 1 deletion packages/x-tree-view/src/internals/useTreeView/extractPluginParamsFromProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,6 @@ export const extractPluginParamsFromProps = <
pluginParams: defaultizedPluginParams,
slots: slots ?? ({} as any),
slotProps: slotProps ?? ({} as any),
experimentalFeatures: experimentalFeatures ?? {},
experimentalFeatures: experimentalFeatures ?? ({} as any),
};
};