[DataGridPro] Fix multi-sorting indicator being cut off #13625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
scope: data grid
|
Deploy preview: https://deploy-preview-13625--material-ui-x.netlify.app/ |
cherniavskii
changed the title
cherniavskii
added
plan: Pro
MBilalShafi
approved these changes
Jun 25, 2024
|
I will check it out in our branch when released. Thank you |
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the multi-sort badge
overlapprop tocircular- this brings the number closer to the icon, and hopefully in most cases will prevent it getting cut off as seen in the issue below.Tested on macOS Chrome, Safari and Firefox.
https://deploy-preview-13625--material-ui-x.netlify.app/x/react-data-grid/sorting/#multi-sorting
Fixes #13406
Before
After