Skip to content

Commit 01874df

Browse files
MDL-87757 block_myoverview: Remove navigation role and behat update
- Removal of the navigation role on main and zero-state template - Add accessibility extra tests for the block_overview
1 parent 1ef7708 commit 01874df

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

public/blocks/myoverview/templates/main.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
{}
2424
}}
2525

26-
<div id="block-myoverview-{{uniqid}}" class="block-myoverview block-cards" data-region="myoverview" role="navigation">
26+
<div id="block-myoverview-{{uniqid}}" class="block-myoverview block-cards" data-region="myoverview">
2727
<div role="search" data-region="filter" class="d-flex align-items-center my-2" aria-label="{{#str}} aria:controls, block_myoverview {{/str}}">
2828
<div class="d-flex flex-wrap gap-1 align-items-center w-100">
2929
{{> block_myoverview/nav-grouping-selector }}

public/blocks/myoverview/templates/zero-state.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
}
4545
}}
4646

47-
<div class="block-myoverview block-cards" data-region="myoverview" role="navigation">
47+
<div class="block-myoverview block-cards" data-region="myoverview">
4848
<div class="container-fluid p-0">
4949
<div class="text-xs-center text-center mt-3" data-region="empty-message">
5050
<img class="empty-placeholder-image-lg mt-1"

public/blocks/myoverview/tests/behat/block_myoverview_dashboard.feature

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,7 @@ Feature: The my overview block allows users to easily access their courses
322322
Then I should not see "Category 1" in the "Course overview" "block"
323323

324324
@accessibility
325-
Scenario: The dashboard page must have sufficient colour contrast
325+
Scenario: The dashboard page must have sufficient colour contrast and pass accessibility checks
326326
When I am on the "My courses" page logged in as "student1"
327327
Then the page should meet "wcag143" accessibility standards
328+
And the page should meet accessibility standards with "best-practice" extra tests

0 commit comments

Comments
 (0)