Add luacheck (#1)

* add luacheck workflow and config
* replace 'digiline' with 'digilines'
* fix whitespace
* fix most variable warnings
* piston.lua and movestone.lua have inline ignores for some hard to fix code
* increase line length for now

Author: OgelGames

.github/workflows/luacheck.yml

@@ -0,0 +1,13 @@
+name: luacheck
+on: [push, pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: apt
+      run: sudo apt-get install -y luarocks
+    - name: luacheck install
+      run: luarocks install --local luacheck
+    - name: luacheck run
+      run: $HOME/.luarocks/bin/luacheck ./

.luacheckrc

@@ -0,0 +1,22 @@
+unused_args = false
+max_line_length = 300  -- TODO: fix line lengths
+
+globals = {
+    "minetest",
+	"digistuff",
+	"digilines",
+}
+
+read_globals = {
+	-- Builtin
+	table = {fields = {"copy"}},
+
+	"vector",
+	"ItemStack",
+	"DIR_DELIM",
+	
+	-- Mod Deps
+	"default",
+	"mesecon",
+	"screwdriver",
+}

camera.lua

@@ -7,8 +7,7 @@ minetest.register_node("digistuff:camera", {
 		"digistuff_camera_back.png",
 		"digistuff_camera_front.png",
 	},
-	digiline = 
-	{
+	digiline = {
 		receptor = {}
 	},
 	_digistuff_channelcopier_fieldname = "channel",
@@ -75,15 +74,14 @@ minetest.register_abm({
 			local players_found = {}
 			local objs = minetest.get_objects_inside_radius(spot,radius)
 			if objs then
-				local _,obj
 				for _,obj in ipairs(objs) do
 					if obj:is_player() then
 						table.insert(players_found,obj:get_player_name())
 						found_any = true
 					end
 				end
 				if found_any then
-					digiline:receptor_send({x=pos.x,y=pos.y-1,z=pos.z}, digiline.rules.default, channel, players_found)
+					digilines.receptor_send({x=pos.x,y=pos.y-1,z=pos.z}, digilines.rules.default, channel, players_found)
 				end
 			end
 		end

cardreader.lua

@@ -28,14 +28,13 @@ minetest.register_craftitem("digistuff:card",{
 			local data = meta:get_string("writedata")
 			meta:set_int("writepending",0)
 			meta:set_string("infotext","Ready to Read")
-			digiline:receptor_send(pos,cardreader_rules,channel,{event = "write",})
+			digilines.receptor_send(pos,cardreader_rules,channel,{event = "write",})
 			stackmeta:set_string("data",data)
 			stackmeta:set_string("description",string.format("Magnetic Card (%s)",meta:get_string("writedescription")))
 			return stack
 		else
-			local channel = meta:get_string("channel")
 			local data = stackmeta:get_string("data")
-			digiline:receptor_send(pos,cardreader_rules,channel,{event = "read",data = data,})
+			digilines.receptor_send(pos,cardreader_rules,channel,{event = "read",data = data,})
 		end
 	end,
 })

conductors.lua

@@ -79,7 +79,6 @@ minetest.register_node("digistuff:junctionbox", {
 	paramtype2 = "facedir",
 	groups = {cracky = 3},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -124,7 +123,6 @@ minetest.register_node("digistuff:receiver", {
 	groups = {dig_immediate = 3,not_in_creative_inventory = 1,},
 	drop = "digilines:wire_std_00000000",
 	is_ground_content = false,
-	paramtype = "light",
 	paramtype2 = "facedir",
 	walkable = false,
 	drawtype = "nodebox",
@@ -190,7 +188,6 @@ minetest.register_node("digistuff:vertical_tap", {
 	paramtype = "light",
 	groups = {dig_immediate = 3,vertical_digiline = 1,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -228,7 +225,6 @@ minetest.register_node("digistuff:vertical_bottom", {
 	paramtype = "light",
 	groups = {dig_immediate = 3,vertical_digiline = 1,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -267,7 +263,6 @@ minetest.register_node("digistuff:vertical_middle", {
 	groups = {dig_immediate = 3,not_in_creative_inventory = 1,vertical_digiline = 1,},
 	drop = "digistuff:vertical_bottom",
 	is_ground_content = false,
-	paramtype = "light",
 	walkable = false,
 	drawtype = "nodebox",
 	node_box = {
@@ -296,7 +291,6 @@ minetest.register_node("digistuff:vertical_top", {
 	groups = {dig_immediate = 3,not_in_creative_inventory = 1,vertical_digiline = 1,},
 	drop = "digistuff:vertical_bottom",
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -336,7 +330,6 @@ minetest.register_node("digistuff:insulated_straight", {
 	on_rotate = minetest.get_modpath("screwdriver") and screwdriver.rotate_simple,
 	groups = {dig_immediate = 3,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -382,7 +375,6 @@ minetest.register_node("digistuff:insulated_tjunction", {
 	on_rotate = minetest.get_modpath("screwdriver") and screwdriver.rotate_simple,
 	groups = {dig_immediate = 3,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -430,7 +422,6 @@ minetest.register_node("digistuff:insulated_corner", {
 	on_rotate = minetest.get_modpath("screwdriver") and screwdriver.rotate_simple,
 	groups = {dig_immediate = 3,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",
@@ -475,7 +466,6 @@ minetest.register_node("digistuff:insulated_fourway", {
 	walkable = false,
 	groups = {dig_immediate = 3,},
 	is_ground_content = false,
-	paramtype = "light",
 	drawtype = "nodebox",
 	node_box = {
 		type = "fixed",

controller.lua

@@ -31,14 +31,14 @@ local function process_inputs(pos)
 	local name = players_on_controller[hash]
 	local player = minetest.get_player_by_name(name)
 	if not player then
-		digiline:receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
+		digilines.receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
 		minetest.get_meta(pos):set_string("infotext","Digilines Game Controller Ready\n(right-click to use)")
 		players_on_controller[hash] = nil
 		return
 	end
 	local distance = vector.distance(pos,player:get_pos())
 	if distance > 1 then
-		digiline:receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
+		digilines.receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
 		minetest.get_meta(pos):set_string("infotext","Digilines Game Controller Ready\n(right-click to use)")
 		player:set_physics_override({speed = 1,jump = 1,})
 		players_on_controller[hash] = nil
@@ -61,10 +61,10 @@ local function process_inputs(pos)
 	last_seen_inputs[name] = inputs
 	if send_needed then
 		local channel = meta:get_string("channel")
-		local inputs = table.copy(inputs)
+		inputs = table.copy(inputs)
 		inputs.look_vector = player:get_look_dir()
 		inputs.name = name
-		digiline:receptor_send(pos,digiline_rules,channel,inputs)
+		digilines.receptor_send(pos,digiline_rules,channel,inputs)
 	end
 end
 
@@ -80,7 +80,7 @@ local function release_player(pos)
 	meta:set_string("infotext","Digilines Game Controller Ready\n(right-click to use)")
 	last_seen_inputs[players_on_controller[hash]] = nil
 	players_on_controller[hash] = nil
-	digiline:receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
+	digilines.receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
 end
 
 local function trap_player(pos,player)
@@ -181,7 +181,6 @@ minetest.register_node("digistuff:controller_programmed", {
 			toggle_trap_player(pos,clicker)
 		end
 	end,
-	_digistuff_channelcopier_fieldname = "channel",
 	digiline = {
 		receptor = {},
 		wire = {
@@ -222,7 +221,7 @@ minetest.register_lbm({
 	action = function(pos)
 		if not players_on_controller[minetest.hash_node_position(pos)] then
 			local meta = minetest.get_meta(pos)
-			digiline:receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
+			digilines.receptor_send(pos,digiline_rules,meta:get_string("channel"),"player_left")
 			meta:set_string("infotext","Digilines Game Controller Ready\n(right-click to use)")
 		end
 	end,

detector.lua

@@ -2,8 +2,7 @@ minetest.register_node("digistuff:detector", {
 	tiles = {
 	"digistuff_digidetector.png"
 	},
-	digiline = 
-	{
+	digiline = {
 		receptor = {}
 	},
 	groups = {cracky=2},
@@ -40,15 +39,14 @@ minetest.register_abm({
 			if not radius or not tonumber(radius) or tonumber(radius) < 1 or tonumber(radius) > 10 then radius = 6 end
 			local objs = minetest.get_objects_inside_radius(pos, radius)
 			if objs then
-				local _,obj
 				for _,obj in ipairs(objs) do
 					if obj:is_player() then
 						table.insert(players_found,obj:get_player_name())
 						found_any = true
 					end
 				end
 				if found_any then
-					digiline:receptor_send(pos, digiline.rules.default, channel, players_found)
+					digilines.receptor_send(pos, digilines.rules.default, channel, players_found)
 				end
 			end
 		end

gpu.lua

@@ -20,9 +20,9 @@ local function rgbtohsv(r,g,b)
 	r = r/255
 	g = g/255
 	b = b/255
-	max = math.max(r,g,b)
-	min = math.min(r,g,b)
-	delta = max-min
+	local max = math.max(r,g,b)
+	local min = math.min(r,g,b)
+	local delta = max-min
 	local hue = 0
 	if delta > 0 then
 		if max == r then
@@ -73,7 +73,7 @@ local function hsvtorgb(h,s,v)
 		b = c
 	else
 		r = c
-		b = x 
+		b = x
 	end
 	r = r+m
 	g = g+m
@@ -199,7 +199,7 @@ local function runcommand(pos,meta,command)
 		if string.len(buffer) == 0 then return end
 		buffer = minetest.deserialize(buffer)
 		if type(buffer) == "table" then
-			digiline:receptor_send(pos,digiline.rules.default,command.channel,buffer)
+			digilines.receptor_send(pos,digilines.rules.default,command.channel,buffer)
 		end
 	elseif command.command == "drawrect" then
 		if type(command.buffer) ~= "number" or type(command.x1) ~= "number" or type(command.y1) ~= "number" or type(command.x2) ~= "number" or type(command.y2) ~= "number" then return end
@@ -400,8 +400,7 @@ minetest.register_node("digistuff:gpu", {
 		local meta = minetest.get_meta(pos)
 		if fields.channel then meta:set_string("channel",fields.channel) end
 	end,
-	digiline = 
-	{
+	digiline = {
 		receptor = {},
 		effector = {
 			action = function(pos,node,channel,msg)

ioexpander.lua

@@ -65,7 +65,7 @@ local ioexp_digiline_send = function(pos)
 	}
 	local outstate = explode_port_states(meta:get_int("outstate"))
 	for k,v in pairs(outstate) do port[k] = port[k] or v end
-	digiline:receptor_send(pos,digiline.rules.default,channel,port)
+	digilines.receptor_send(pos,digilines.rules.default,channel,port)
 end
 
 local ioexp_handle_digilines = function(pos,node,channel,msg)
@@ -99,7 +99,6 @@ local ioexp_handle_mesecons = function(pos,_,rule,state)
 	local meta = minetest.get_meta(pos)
 	local port = ioexp_rule_to_port(rule)
 	if not port then return end
-	local meta = minetest.get_meta(pos)
 	meta:set_int(port.."on",state == "on" and 1 or 0)
 	ioexp_digiline_send(pos)
 end

memory.lua

@@ -44,16 +44,15 @@ minetest.register_node("digistuff:ram", {
 		local meta = minetest.get_meta(pos)
 		if fields.channel then meta:set_string("channel",fields.channel) end
 	end,
-	digiline = 
-	{
+	digiline = {
 		receptor = {},
 		effector = {
 			action = function(pos,node,channel,msg)
 				local meta = minetest.get_meta(pos)
 				if meta:get_string("channel") ~= channel or type(msg) ~= "table" then return end
 				if msg.command == "read" then
 					if type(msg.address) == "number" and msg.address >= 0 and msg.address <= 31 then
-						digiline:receptor_send(pos,digiline.rules.default,channel,meta:get_string(string.format("data%02i",math.floor(msg.address))))					
+						digilines.receptor_send(pos,digilines.rules.default,channel,meta:get_string(string.format("data%02i",math.floor(msg.address))))
 					end
 				elseif msg.command == "write" then
 					if type(msg.address) == "number" and msg.address >= 0 and msg.address <= 31 and type(msg.data) == "string" then
@@ -137,16 +136,15 @@ minetest.register_node("digistuff:eeprom", {
 		local meta = minetest.get_meta(pos)
 		if fields.channel then meta:set_string("channel",fields.channel) end
 	end,
-	digiline = 
-	{
+	digiline = {
 		receptor = {},
 		effector = {
 			action = function(pos,node,channel,msg)
 				local meta = minetest.get_meta(pos)
 				if meta:get_string("channel") ~= channel or type(msg) ~= "table" then return end
 				if msg.command == "read" then
 					if type(msg.address) == "number" and msg.address >= 0 and msg.address <= 31 then
-						digiline:receptor_send(pos,digiline.rules.default,channel,meta:get_string(string.format("data%02i",math.floor(msg.address))))					
+						digilines.receptor_send(pos,digilines.rules.default,channel,meta:get_string(string.format("data%02i",math.floor(msg.address))))
 					end
 				elseif msg.command == "write" then
 					if type(msg.address) == "number" and msg.address >= 0 and msg.address <= 31 and type(msg.data) == "string" then