Skip to content

Commit 9adde93

Browse files
vivekverma-aristamssonicbld
authored andcommitted
Fix fixture invocation order in qos/qos_sai_base.py (sonic-net#12152)
What is the motivation for this PR? qos/test_qos_sai.py fail with the following - failed on setup with "Failed: Not all critical processes are healthy" The fixture dut_disable_ipv6 disables ipv6 due to which the following critical processes don't come up after swapping syncd ( fixture swapSyncd_on_selected_duts ) - program:snmpd program:snmp-subagent And this issue only hits if swapSyncd_on_selected_duts is executed after dut_disable_ipv6 and since there is no dependency between these fixtures, they can execute in any order. How did you do it? This change introduces a dependency between dut_disable_ipv6 & swapSyncd_on_selected_duts such that former is always executed after latter. How did you verify/test it? Tested on Arista-7050CX3 platform with dualtor topology.
1 parent 83a35c0 commit 9adde93

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

tests/qos/qos_sai_base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1730,7 +1730,8 @@ def populateArpEntries(
17301730
return
17311731

17321732
@pytest.fixture(scope='class', autouse=True)
1733-
def dut_disable_ipv6(self, duthosts, get_src_dst_asic_and_duts, tbinfo, lower_tor_host): # noqa F811
1733+
def dut_disable_ipv6(self, duthosts, get_src_dst_asic_and_duts, tbinfo, lower_tor_host, # noqa F811
1734+
swapSyncd_on_selected_duts):
17341735
for duthost in get_src_dst_asic_and_duts['all_duts']:
17351736
docker0_ipv6_addr = \
17361737
duthost.shell("sudo ip -6 addr show dev docker0 | grep global" + " | awk '{print $2}'")[

0 commit comments

Comments
 (0)