Skip to content

WebGPURenderer: Fix MSAA using mipmap levels #31544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2025
Merged

WebGPURenderer: Fix MSAA using mipmap levels #31544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0b4a6
WebGPU: Fix MSAA using mipmap levels
NoxDawnsong Aug 1, 2025
d3b368e
Change comment to link to official specification
NoxDawnsong Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/renderers/webgpu/utils/WebGPUTextureUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ class WebGPUTextureUtils {

msaaTextureDescriptorGPU.label = msaaTextureDescriptorGPU.label + '-msaa';
msaaTextureDescriptorGPU.sampleCount = samples;
msaaTextureDescriptorGPU.mipLevelCount = 1; // See https://www.w3.org/TR/webgpu/#texture-creation
Copy link
Collaborator

@Mugen87 Mugen87 Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunag Should be report warning to the user if samples is set to a value greater than 0 and mipmapping is enabled? In engine components like FX modules, we can control this ourselves when creating render targets but I wonder if this kind of patch leads to unexpected behavior on user level.

Copy link
Collaborator

@sunag sunag Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. good question, I can't calculate it right away either, we can merge and test during the r180dev I think.


textureData.msaaTexture = backend.device.createTexture( msaaTextureDescriptorGPU );

Expand Down