From a6a351394cc278f60d78b064bf22453a459aa0ca Mon Sep 17 00:00:00 2001 From: Renaud Rohlinger Date: Mon, 27 Nov 2023 12:30:38 +0900 Subject: [PATCH 1/2] missing options constructor --- src/renderers/WebGL3DRenderTarget.js | 18 +++++++----------- src/renderers/WebGLArrayRenderTarget.js | 18 +++++++----------- 2 files changed, 14 insertions(+), 22 deletions(-) diff --git a/src/renderers/WebGL3DRenderTarget.js b/src/renderers/WebGL3DRenderTarget.js index 2d0727f272d909..62d6469d54f494 100644 --- a/src/renderers/WebGL3DRenderTarget.js +++ b/src/renderers/WebGL3DRenderTarget.js @@ -2,21 +2,17 @@ import { WebGLRenderTarget } from './WebGLRenderTarget.js'; import { Data3DTexture } from '../textures/Data3DTexture.js'; class WebGL3DRenderTarget extends WebGLRenderTarget { + constructor(width = 1, height = 1, depth = 1) { + super(width, height); - constructor( width = 1, height = 1, depth = 1 ) { + this.isWebGL3DRenderTarget = true; - super( width, height ); + this.depth = depth; - this.isWebGL3DRenderTarget = true; - - this.depth = depth; - - this.texture = new Data3DTexture( null, width, height, depth ); - - this.texture.isRenderTargetTexture = true; - - } + this.texture = new Data3DTexture(null, width, height, depth); + this.texture.isRenderTargetTexture = true; + } } export { WebGL3DRenderTarget }; diff --git a/src/renderers/WebGLArrayRenderTarget.js b/src/renderers/WebGLArrayRenderTarget.js index a968ec2ed529a8..c2d6dfe6a2c247 100644 --- a/src/renderers/WebGLArrayRenderTarget.js +++ b/src/renderers/WebGLArrayRenderTarget.js @@ -2,21 +2,17 @@ import { WebGLRenderTarget } from './WebGLRenderTarget.js'; import { DataArrayTexture } from '../textures/DataArrayTexture.js'; class WebGLArrayRenderTarget extends WebGLRenderTarget { + constructor(width = 1, height = 1, depth = 1, options = {}) { + super(width, height, options); - constructor( width = 1, height = 1, depth = 1 ) { + this.isWebGLArrayRenderTarget = true; - super( width, height ); + this.depth = depth; - this.isWebGLArrayRenderTarget = true; - - this.depth = depth; - - this.texture = new DataArrayTexture( null, width, height, depth ); - - this.texture.isRenderTargetTexture = true; - - } + this.texture = new DataArrayTexture(null, width, height, depth); + this.texture.isRenderTargetTexture = true; + } } export { WebGLArrayRenderTarget }; From 353082c09a337f136820db6174894fbf22a85baf Mon Sep 17 00:00:00 2001 From: Renaud Rohlinger Date: Mon, 27 Nov 2023 12:32:58 +0900 Subject: [PATCH 2/2] cleanup format --- src/renderers/WebGL3DRenderTarget.js | 18 +++++++++++------- src/renderers/WebGLArrayRenderTarget.js | 18 +++++++++++------- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/renderers/WebGL3DRenderTarget.js b/src/renderers/WebGL3DRenderTarget.js index 62d6469d54f494..be074da600eed1 100644 --- a/src/renderers/WebGL3DRenderTarget.js +++ b/src/renderers/WebGL3DRenderTarget.js @@ -2,17 +2,21 @@ import { WebGLRenderTarget } from './WebGLRenderTarget.js'; import { Data3DTexture } from '../textures/Data3DTexture.js'; class WebGL3DRenderTarget extends WebGLRenderTarget { - constructor(width = 1, height = 1, depth = 1) { - super(width, height); - this.isWebGL3DRenderTarget = true; + constructor( width = 1, height = 1, depth = 1, options = {} ) { - this.depth = depth; + super( width, height, options ); - this.texture = new Data3DTexture(null, width, height, depth); + this.isWebGL3DRenderTarget = true; + + this.depth = depth; + + this.texture = new Data3DTexture( null, width, height, depth ); + + this.texture.isRenderTargetTexture = true; + + } - this.texture.isRenderTargetTexture = true; - } } export { WebGL3DRenderTarget }; diff --git a/src/renderers/WebGLArrayRenderTarget.js b/src/renderers/WebGLArrayRenderTarget.js index c2d6dfe6a2c247..769f9e5e0e79c8 100644 --- a/src/renderers/WebGLArrayRenderTarget.js +++ b/src/renderers/WebGLArrayRenderTarget.js @@ -2,17 +2,21 @@ import { WebGLRenderTarget } from './WebGLRenderTarget.js'; import { DataArrayTexture } from '../textures/DataArrayTexture.js'; class WebGLArrayRenderTarget extends WebGLRenderTarget { - constructor(width = 1, height = 1, depth = 1, options = {}) { - super(width, height, options); - this.isWebGLArrayRenderTarget = true; + constructor( width = 1, height = 1, depth = 1, options = {} ) { - this.depth = depth; + super( width, height, options ); - this.texture = new DataArrayTexture(null, width, height, depth); + this.isWebGLArrayRenderTarget = true; + + this.depth = depth; + + this.texture = new DataArrayTexture( null, width, height, depth ); + + this.texture.isRenderTargetTexture = true; + + } - this.texture.isRenderTargetTexture = true; - } } export { WebGLArrayRenderTarget };