Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 6, 2021

Related issue: #21712

Description

Ensures correct code style in new WebXR code.

@Mugen87 Mugen87 added this to the r129 milestone May 6, 2021
@Mugen87 Mugen87 merged commit a51bed7 into mrdoob:dev May 6, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 6, 2021

@fe1ixz @mrdoob While fixing the code style, I have noticed two things:

  • TOUCH_RADIUS is undefined.

const indexSphere = new Sphere( pointerPosition, TOUCH_RADIUS );

  • handedness is undefined, too.

console.warn( `Couldn't find ${jointName} in ${handedness} hand mesh` );

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

  • TOUCH_RADIUS is undefined.

Fixed. 2c9b143

  • handedness is undefined, too.

@fe1ixz What's the fix for this one?

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

  • handedness is undefined, too.

Should be fixed now. 571347f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants