From eeb4fcbae13471864cafd91d084455495320fc69 Mon Sep 17 00:00:00 2001 From: Mugen87 Date: Tue, 20 Apr 2021 10:16:56 +0200 Subject: [PATCH] Examples: Clean up. --- .../renderers/webgl/nodes/WebGLNodeBuilder.js | 6 ++-- .../jsm/renderers/webgl/nodes/WebGLNodes.js | 2 +- examples/webgl_materials_standard_nodes.html | 36 ++++++++----------- 3 files changed, 19 insertions(+), 25 deletions(-) diff --git a/examples/jsm/renderers/webgl/nodes/WebGLNodeBuilder.js b/examples/jsm/renderers/webgl/nodes/WebGLNodeBuilder.js index fd98e8cfdc5d55..f267573dd29f25 100644 --- a/examples/jsm/renderers/webgl/nodes/WebGLNodeBuilder.js +++ b/examples/jsm/renderers/webgl/nodes/WebGLNodeBuilder.js @@ -53,7 +53,7 @@ class WebGLNodeBuilder extends NodeBuilder { let snippet = ''; - for ( let uniform of uniforms ) { + for ( const uniform of uniforms ) { if ( uniform.type === 'texture' ) { @@ -61,7 +61,7 @@ class WebGLNodeBuilder extends NodeBuilder { } else { - let vectorType = this.getVectorType( uniform.type ); + const vectorType = this.getVectorType( uniform.type ); snippet += `uniform ${vectorType} ${uniform.name};`; @@ -89,7 +89,7 @@ class WebGLNodeBuilder extends NodeBuilder { const uniforms = this.uniforms[ 'fragment' ]; - for ( let uniform of uniforms ) { + for ( const uniform of uniforms ) { this.properties.uniforms[ uniform.name ] = uniform; diff --git a/examples/jsm/renderers/webgl/nodes/WebGLNodes.js b/examples/jsm/renderers/webgl/nodes/WebGLNodes.js index fc6bc84b3fefff..7efa1034f19b23 100644 --- a/examples/jsm/renderers/webgl/nodes/WebGLNodes.js +++ b/examples/jsm/renderers/webgl/nodes/WebGLNodes.js @@ -21,7 +21,7 @@ function addCodeAfterSnippet( source, snippet, code ) { Material.prototype.onBuild = function ( parameters, renderer ) { - const nodeBuilder = new WebGLNodeBuilder( this, renderer, parameters ).build(); + new WebGLNodeBuilder( this, renderer, parameters ).build(); let fragmentShader = parameters.fragmentShader; diff --git a/examples/webgl_materials_standard_nodes.html b/examples/webgl_materials_standard_nodes.html index b407c68f14a851..0ce972370407e7 100644 --- a/examples/webgl_materials_standard_nodes.html +++ b/examples/webgl_materials_standard_nodes.html @@ -30,8 +30,6 @@ import Vector3Node from './jsm/renderers/nodes/inputs/Vector3Node.js'; import OperatorNode from './jsm/renderers/nodes/math/OperatorNode.js'; - const statsEnabled = true; - let container, stats; let camera, scene, renderer, controls; @@ -118,7 +116,7 @@ }; - function loadEnvironment(name) { + function loadEnvironment( name ) { if ( environments[ name ].texture !== undefined ) { @@ -130,18 +128,18 @@ const filename = environments[ name ].filename; new RGBELoader() - .setDataType( THREE.UnsignedByteType ) - .setPath( 'textures/equirectangular/' ) - .load( filename, function ( hdrEquirect ) { + .setDataType( THREE.UnsignedByteType ) + .setPath( 'textures/equirectangular/' ) + .load( filename, function ( hdrEquirect ) { - const hdrCubeRenderTarget = pmremGenerator.fromEquirectangular( hdrEquirect ); - hdrEquirect.dispose(); + const hdrCubeRenderTarget = pmremGenerator.fromEquirectangular( hdrEquirect ); + hdrEquirect.dispose(); - scene.background = hdrCubeRenderTarget.texture; - scene.environment = hdrCubeRenderTarget.texture; - environments[ name ].texture = hdrCubeRenderTarget.texture; + scene.background = hdrCubeRenderTarget.texture; + scene.environment = hdrCubeRenderTarget.texture; + environments[ name ].texture = hdrCubeRenderTarget.texture; - } ); + } ); } @@ -153,9 +151,9 @@ loadEnvironment( params.environment ); const gui = new GUI(); - gui.add( params, 'environment', Object.keys( environments ) ).onChange( function( value ) { + gui.add( params, 'environment', Object.keys( environments ) ).onChange( function ( value ) { - loadEnvironment(value); + loadEnvironment( value ); } ); gui.open(); @@ -165,12 +163,8 @@ // - if ( statsEnabled ) { - - stats = new Stats(); - container.appendChild( stats.dom ); - - } + stats = new Stats(); + container.appendChild( stats.dom ); window.addEventListener( 'resize', onWindowResize ); @@ -196,7 +190,7 @@ controls.update(); renderer.render( scene, camera ); - if ( statsEnabled ) stats.update(); + stats.update(); }