Skip to content

Conversation

@elalish
Copy link
Contributor

@elalish elalish commented Jan 28, 2021

Thanks to @donmccurdy we now have support for KTX2 textures, both in and out of glTF. This is just adding documentation (largely copied from the BasisTextureLoader docs).

It also includes a small update to the .d.ts file for KTX2Loader, so it might be nice to include this in the next point release, @mrdoob.

@donmccurdy
Copy link
Collaborator

Might be good to include a copy of KTX2Loader.html in the zh/ folder as well, it can be translated later. Otherwise looks good!

@mrdoob mrdoob changed the base branch from dev to master January 29, 2021 12:12
@mrdoob mrdoob added this to the r125 milestone Jan 29, 2021
@mrdoob mrdoob merged commit 2eb9419 into mrdoob:master Jan 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 29, 2021

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2021

Notice this PR targeted the master branch. #21168, too.

@mrdoob
Copy link
Owner

mrdoob commented Jan 29, 2021

Yep, changed it myself. This requires a point release.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2021

BTW: Is there a way to prevent PRs targeting master?

@mrdoob
Copy link
Owner

mrdoob commented Jan 29, 2021

Well, maybe this one was not required for the point release, but while I was at it... 😇

@mrdoob
Copy link
Owner

mrdoob commented Jan 29, 2021

BTW: Is there a way to prevent PRs targeting master?

I do not know, I wish there was a way. But at the same time, I wouldn't want to lose the flexibility.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2021

Ah okay! I was not aware you have changed the branch^^.

@mrdoob
Copy link
Owner

mrdoob commented Jan 29, 2021

Yeah, I was trying to push 0.125.2 to npm without the other changes in dev.

I think I did it correctly but somehow I ended up merging master and dev afterwards?

Anyway, should be good now I think🤞

@mrdoob
Copy link
Owner

mrdoob commented Jan 30, 2021

Oh, I see what I did. I didn't think this was built on top of the latests in dev. I should have cherry-picked instead...

Anyway, I'm a git-noob still 😁

@ozoneuniverse
Copy link

Amazing momentum Everyone! Cheers! and Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants