Skip to content

Conversation

@cloud9c
Copy link
Contributor

@cloud9c cloud9c commented Jan 1, 2021

Added LightProbe to the list of parse-able objects in the ObjectLoader documentation

@cloud9c cloud9c changed the title Add LightProbe to the list of object types Docs: Add LightProbe to the list of object types Jan 1, 2021
@cloud9c cloud9c changed the title Docs: Add LightProbe to the list of object types Docs: Add LightProbe to the object list in ObjectLoader Jan 1, 2021
@mrdoob mrdoob added this to the r125 milestone Jan 2, 2021
@mrdoob mrdoob merged commit b3ddccf into mrdoob:dev Jan 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 2, 2021

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 2, 2021

@mrdoob Listings like in ObjectLoader.parseObject() can easily get out of date and are thus hard to maintain. Next to LightProbe, the classes RectAreaLight, SkinnedMesh and InstancedMesh are also missing.

How about removing it? I mean the listing comes from a time where ObjectLoader did only partly support 3D objects. Right now, all classes from src/objects and all non-experimental lights are supported.

@mrdoob
Copy link
Owner

mrdoob commented Jan 2, 2021

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants