-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Update rollup config #14912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rollup config #14912
Conversation
|
Looks like closure builder is a better choice, I remove uglify. |
|
I update the rollup config recently. class BoxGeometry extends Geometry{ The code would be more readable and more friendly for module developing. Another thing is I also add some babel's plugin-proposal. For example we can use these codes like: // Then in Three.js file Other proposal gramma features like class-properties, decorators, object-rest-spread, optional-chaining which are very common used in project developing has already been config. |
|
I would love to see ES6 widely adopted in threejs. I know there has been a lot of discussion about performance and reverse compatibility issues in #11552 and #14654 (and few other issues I cant find right now).
If this works and performs more or less same as current code, that would be a very encouraging! Also, it might be a god idea to squash those 15 commits considering this is a very small PR. |
|
Closing, see #14912 (comment) |
I add some more rollup plugins and update some configs.