Matrix3/4: Constructor has now parameters. (#26021)

Author: Mugen87

docs/api/en/math/Matrix3.html

@@ -21,7 +21,7 @@ <h2>Code Example</h2>
 
 		<h2>A Note on Row-Major and Column-Major Ordering</h2>
 		<p>
-			The [page:set]() method takes arguments in
+			The constructor and [page:set]() method take arguments in
 			[link:https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order row-major] 
 			order, while internally they are stored in the [page:.elements elements] 
 			array in column-major order.<br /><br />
@@ -49,10 +49,12 @@ <h2>A Note on Row-Major and Column-Major Ordering</h2>
 
 		<h2>Constructor</h2>
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13],
+			[param:Number n21], [param:Number n22], [param:Number n22],
+			[param:Number n31], [param:Number n32], [param:Number n33] )</h3>
 		<p>
-			Creates and initializes the [name] to the 3x3
-			[link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
+			Creates a 3x3 matrix with the given arguments in row-major order. If no arguments are provided, the constructor initializes
+			the [name] to the 3x3 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
 		</p>
 
 		<h2>Properties</h2>

docs/api/en/math/Matrix4.html

@@ -62,7 +62,7 @@ <h1>[name]</h1>
 
 		<h2>A Note on Row-Major and Column-Major Ordering</h2>
 		<p>
-			The [page:set]() method takes arguments in
+			The constructor and [page:set]() method take arguments in
 			[link:https://en.wikipedia.org/wiki/Row-_and_column-major_order#Column-major_order row-major] 
 			order, while internally they are stored in the [page:.elements elements] array in column-major order.<br /><br />
 
@@ -117,11 +117,14 @@ <h2>Extracting position, rotation and scale</h2>
 
 		<h2>Constructor</h2>
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13], [param:Number n14],
+			[param:Number n21], [param:Number n22], [param:Number n23], [param:Number n24],
+			[param:Number n31], [param:Number n32], [param:Number n33], [param:Number n34],
+			[param:Number n41], [param:Number n42], [param:Number n43], [param:Number n44] )</h3>
 
 		<p>
-			Creates and initializes the [name] to the 4x4
-			[link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
+			Creates a 4x4 matrix with the given arguments in row-major order. If no arguments are provided, the constructor initializes 
+			the [name] to the 4x4 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
 		</p>
 
 		<h2>Properties</h2>

docs/api/it/math/Matrix3.html

@@ -46,10 +46,12 @@ <h2>Una nota sull'ordine delle Row-Major (righe principali) e delle Column-Major
 		<h2>Costruttore</h2>
 
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13],
+			[param:Number n21], [param:Number n22], [param:Number n22],
+			[param:Number n31], [param:Number n32], [param:Number n33] )</h3>
 		<p>
-			Crea e inizializza [name] nella 
-			[link:https://en.wikipedia.org/wiki/Identity_matrix matrice] identità 3x3.
+			Creates a 3x3 matrix with the given arguments in row-major. If no arguments are provided, the constructor initializes
+			the [name] to the 3x3 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
 		</p>
 
 		<h2>Proprietà</h2>

docs/api/it/math/Matrix4.html

@@ -105,11 +105,15 @@ <h2>Estrazione della posizione, della rotazione e del ridimensionamento</h2>
 		<h2>Costruttore</h2>
 
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13], [param:Number n14],
+			[param:Number n21], [param:Number n22], [param:Number n23], [param:Number n24],
+			[param:Number n31], [param:Number n32], [param:Number n33], [param:Number n34],
+			[param:Number n41], [param:Number n42], [param:Number n43], [param:Number n44] )</h3>
 
 		<p>
-			Crea e inizializza [name] nella [link:https://en.wikipedia.org/wiki/Identity_matrix matrice] identità 4x4.
-	</p>
+			Creates a 4x4 matrix with the given arguments in row-major order. If no arguments are provided, the constructor initializes 
+			the [name] to the 4x4 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
+		</p>
 
 		<h2>Proprietà</h2>
 

docs/api/zh/math/Matrix3.html

@@ -43,13 +43,15 @@ <h2>注意行优先列优先的顺序。</h2>
 		<h2>Constructor</h2>
 
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13],
+			[param:Number n21], [param:Number n22], [param:Number n22],
+			[param:Number n31], [param:Number n32], [param:Number n33] )</h3>
 		<p>
-		创建并初始化一个3X3的单位矩阵[link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
+			Creates a 3x3 matrix with the given arguments in row-major order. If no arguments are provided, the constructor initializes
+			the [name] to the 3x3 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
 		</p>
 
 
-
 		<h2>属性（Properties）</h2>
 
 		<h3>[property:Array elements]</h3>

docs/api/zh/math/Matrix4.html

@@ -95,11 +95,15 @@ <h2>提取位置(平移)、旋转和缩放</h2>
 		<h2>构造器（Constructor）</h2>
 
 
-		<h3>[name]()</h3>
+		<h3>[name]( [param:Number n11], [param:Number n12], [param:Number n13], [param:Number n14],
+			[param:Number n21], [param:Number n22], [param:Number n23], [param:Number n24],
+			[param:Number n31], [param:Number n32], [param:Number n33], [param:Number n34],
+			[param:Number n41], [param:Number n42], [param:Number n43], [param:Number n44] )</h3>
 
 		<p>
-			创建并初始化一个4X4的单位矩阵[link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
-	</p>
+			Creates a 4x4 matrix with the given arguments in row-major order. If no arguments are provided, the constructor initializes 
+			the [name] to the 4x4 [link:https://en.wikipedia.org/wiki/Identity_matrix identity matrix].
+		</p>
 
 		<h2>属性（Properties）</h2>
 

src/math/Matrix3.js

@@ -1,6 +1,6 @@
 class Matrix3 {
 
-	constructor() {
+	constructor( n11, n12, n13, n21, n22, n23, n31, n32, n33 ) {
 
 		Matrix3.prototype.isMatrix3 = true;
 
@@ -12,6 +12,12 @@ class Matrix3 {
 
 		];
 
+		if ( n11 !== undefined ) {
+
+			this.set( n11, n12, n13, n21, n22, n23, n31, n32, n33 );
+
+		}
+
 	}
 
 	set( n11, n12, n13, n21, n22, n23, n31, n32, n33 ) {

src/math/Matrix4.js

@@ -2,7 +2,7 @@ import { Vector3 } from './Vector3.js';
 
 class Matrix4 {
 
-	constructor() {
+	constructor( n11, n12, n13, n14, n21, n22, n23, n24, n31, n32, n33, n34, n41, n42, n43, n44 ) {
 
 		Matrix4.prototype.isMatrix4 = true;
 
@@ -15,6 +15,12 @@ class Matrix4 {
 
 		];
 
+		if ( n11 !== undefined ) {
+
+			this.set( n11, n12, n13, n14, n21, n22, n23, n24, n31, n32, n33, n34, n41, n42, n43, n44 );
+
+		}
+
 	}
 
 	set( n11, n12, n13, n14, n21, n22, n23, n24, n31, n32, n33, n34, n41, n42, n43, n44 ) {

test/unit/src/math/Matrix3.tests.js

@@ -69,6 +69,19 @@ export default QUnit.module( 'Maths', () => {
 
 			assert.ok( ! matrixEquals3( a, b ), 'Passed!' );
 
+			const c = new Matrix3( 0, 1, 2, 3, 4, 5, 6, 7, 8 );
+			assert.ok( c.elements[ 0 ] == 0 );
+			assert.ok( c.elements[ 1 ] == 3 );
+			assert.ok( c.elements[ 2 ] == 6 );
+			assert.ok( c.elements[ 3 ] == 1 );
+			assert.ok( c.elements[ 4 ] == 4 );
+			assert.ok( c.elements[ 5 ] == 7 );
+			assert.ok( c.elements[ 6 ] == 2 );
+			assert.ok( c.elements[ 7 ] == 5 );
+			assert.ok( c.elements[ 8 ] == 8 );
+
+			assert.ok( ! matrixEquals3( a, c ), 'Passed!' );
+
 		} );
 
 		// PUBLIC STUFF

test/unit/src/math/Matrix4.tests.js

@@ -72,6 +72,26 @@ export default QUnit.module( 'Maths', () => {
 
 			assert.ok( ! matrixEquals4( a, b ), 'Passed!' );
 
+			const c = new Matrix4( 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 );
+			assert.ok( c.elements[ 0 ] == 0 );
+			assert.ok( c.elements[ 1 ] == 4 );
+			assert.ok( c.elements[ 2 ] == 8 );
+			assert.ok( c.elements[ 3 ] == 12 );
+			assert.ok( c.elements[ 4 ] == 1 );
+			assert.ok( c.elements[ 5 ] == 5 );
+			assert.ok( c.elements[ 6 ] == 9 );
+			assert.ok( c.elements[ 7 ] == 13 );
+			assert.ok( c.elements[ 8 ] == 2 );
+			assert.ok( c.elements[ 9 ] == 6 );
+			assert.ok( c.elements[ 10 ] == 10 );
+			assert.ok( c.elements[ 11 ] == 14 );
+			assert.ok( c.elements[ 12 ] == 3 );
+			assert.ok( c.elements[ 13 ] == 7 );
+			assert.ok( c.elements[ 14 ] == 11 );
+			assert.ok( c.elements[ 15 ] == 15 );
+
+			assert.ok( ! matrixEquals4( a, c ), 'Passed!' );
+
 		} );
 
 		// PUBLIC STUFF