Merge pull request #15470 from trusktr/patch-13

mrdoob · web-flow · commit 3278ab2d5720 · 2018-12-25T22:04:20.000+01:00
fix typo that was forcing CSS3D to update when not necessary
diff --git a/examples/js/renderers/CSS3DRenderer.js b/examples/js/renderers/CSS3DRenderer.js
@@ -184,9 +184,9 @@ THREE.CSS3DRenderer = function () {
 			}
 
 			var element = object.element;
-			var cachedStyle = cache.objects.get( object );
+			var cachedObject = cache.objects.get( object );
 
-			if ( cachedStyle === undefined || cachedStyle !== style ) {
+			if ( cachedObject === undefined || cachedObject.style !== style ) {
 
 				element.style.WebkitTransform = style;
 				element.style.transform = style;

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,9 @@ THREE.CSS3DRenderer = function () {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`var element = object.element;`
`187`		`- var cachedStyle = cache.objects.get( object );`
	`187`	`+ var cachedObject = cache.objects.get( object );`
`188`	`188`
`189`		`- if ( cachedStyle === undefined \|\| cachedStyle !== style ) {`
	`189`	`+ if ( cachedObject === undefined \|\| cachedObject.style !== style ) {`
`190`	`190`
`191`	`191`	`element.style.WebkitTransform = style;`
`192`	`192`	`element.style.transform = style;`