Skip to content

Commit 007b2a0

Browse files
authored
ArcballControls: Remove keydown event listener. (#23028)
1 parent cf5e5f3 commit 007b2a0

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

examples/jsm/controls/ArcballControls.js

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,6 @@ class ArcballControls extends EventDispatcher {
232232
this.domElement.addEventListener( 'pointerdown', this.onPointerDown );
233233
this.domElement.addEventListener( 'pointercancel', this.onPointerCancel );
234234

235-
window.addEventListener( 'keydown', this.onKeyDown );
236235
window.addEventListener( 'resize', this.onWindowResize );
237236

238237
}
@@ -774,28 +773,6 @@ class ArcballControls extends EventDispatcher {
774773

775774
};
776775

777-
onKeyDown = ( event ) => {
778-
779-
if ( event.key == 'c' ) {
780-
781-
if ( event.ctrlKey || event.metaKey ) {
782-
783-
this.copyState();
784-
785-
}
786-
787-
} else if ( event.key == 'v' ) {
788-
789-
if ( event.ctrlKey || event.metaKey ) {
790-
791-
this.pasteState();
792-
793-
}
794-
795-
}
796-
797-
};
798-
799776
onSinglePanStart = ( event, operation ) => {
800777

801778
if ( this.enabled ) {

examples/misc_controls_arcball.html

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@
156156
} );
157157

158158

159+
window.addEventListener( 'keydown', onKeyDown );
159160
window.addEventListener( 'resize', onWindowResize );
160161

161162
//
@@ -238,6 +239,28 @@
238239

239240
}
240241

242+
function onKeyDown( event ) {
243+
244+
if ( event.key === 'c' ) {
245+
246+
if ( event.ctrlKey || event.metaKey ) {
247+
248+
controls.copyState();
249+
250+
}
251+
252+
} else if ( event.key === 'v' ) {
253+
254+
if ( event.ctrlKey || event.metaKey ) {
255+
256+
controls.pasteState();
257+
258+
}
259+
260+
}
261+
262+
}
263+
241264
function setCamera( type ) {
242265

243266
if ( type == 'Orthographic' ) {

0 commit comments

Comments
 (0)