Skip to content

Conversation

@winter-loo
Copy link
Contributor

@winter-loo winter-loo commented Jul 10, 2025

According to the neotest documentation, the strategy should be a table or a function. Current implementation returns a string as the straetegy value in case of failure. See image below in case I forgot to install the codelldb debug adapter.

image

This commit fixes the implementation and refines the error message.
After this fix, the user will see the error message as:

image

when the debug adapter is not installed.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

mrcjkb
mrcjkb previously approved these changes Jul 10, 2025
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb changed the title fix(dap): refine the error message when a debug adapter can not be found fix(dap): confusing error when debug adapter not found Jul 10, 2025
@mrcjkb mrcjkb enabled auto-merge (squash) July 10, 2025 06:58
@mrcjkb mrcjkb disabled auto-merge July 10, 2025 06:58
@mrcjkb mrcjkb enabled auto-merge (squash) July 10, 2025 06:58
@mrcjkb mrcjkb merged commit 91131ac into mrcjkb:master Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants