Skip to content

Conversation

@GordianDziwis
Copy link
Contributor

This fixes an issue where renderDiagnostics opens a seemingly empty float window. The content is there but comes after the visible lines.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@GordianDziwis GordianDziwis changed the title Fix empty renderDiagnostics float fix(renderDiagnostics) empty renderDiagnostics float May 17, 2025
@GordianDziwis GordianDziwis changed the title fix(renderDiagnostics) empty renderDiagnostics float fix(renderDiagnostics): empty float before pushing diagnostics May 17, 2025
@mrcjkb mrcjkb enabled auto-merge (squash) May 18, 2025 00:15
@GordianDziwis GordianDziwis changed the title fix(renderDiagnostics): empty float before pushing diagnostics fix(renderDiagnostics): clear content of diagnostic float before pushing ANSI escaped diagnostics May 18, 2025
auto-merge was automatically disabled May 18, 2025 10:38

Head branch was pushed to by a user without write access

@mrcjkb mrcjkb changed the title fix(renderDiagnostics): clear content of diagnostic float before pushing ANSI escaped diagnostics fix(ui/renderDiagnostics): seemingly empty float window May 18, 2025
@mrcjkb mrcjkb enabled auto-merge (squash) May 18, 2025 12:35
@mrcjkb mrcjkb merged commit 4079a18 into mrcjkb:master May 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants