fix(ui): nil safety in codeAction Group
#487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using #M.state.actions.group stops (and returns 0) when a nil is encountered. Use vim.tbl_count() instead which will return an integer
Contributor
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
dsully
changed the title
mrcjkb
approved these changes
Aug 26, 2024
Owner
mrcjkb
left a comment
mrcjkb
left a comment
There was a problem hiding this comment.
Thanks 🙏
I'll prepare a new release when I'm near my laptop.
mrcjkb
changed the title
nil safety in codeAction Group
This was referenced Nov 10, 2024
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#M.state.actions.groupstops (and returns 0) when a nil is encountered.Use
vim.tbl_count()instead which will return an integer