Skip to content

Conversation

@jannes
Copy link
Contributor

@jannes jannes commented Aug 13, 2024

I tested this and it fixes #465, the clear/cancel subcommands for flyCheck command work.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@mrcjkb mrcjkb changed the title Fix argument for clear/cancel flycheck fix(diagnostic): pass correct flycheck arg for clear/cancel Aug 13, 2024
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

":RustLsp flyCheck clear" crahes rust-analyzer

2 participants