feat(ui): add open_split_vertical option for splits opened
#387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
requested changes
May 10, 2024
Owner
mrcjkb
left a comment
mrcjkb
left a comment
There was a problem hiding this comment.
Thanks for your contribution 😃🙏
mrcjkb
changed the title
open_split_vertical option for splits openedopen_split_vertical option for splits opened
dwtong
force-pushed
the
split-config
branch
2 times, most recently
from
74312b8 to
d578572
Compare
when opening splits from a floating window with the "Open in split"
option, this will set the split to open vertically.
configure with:
```lua
vim.g.rustaceanvim = {
tools = {
float_win_config = {
open_split = 'vertical',
},
},
}
```
Contributor
Author
|
i have made the requested changes - if you're happy with them then it's all ready to go :) |
mrcjkb
reviewed
May 10, 2024
mrcjkb
approved these changes
May 10, 2024
This was referenced Nov 10, 2024
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when opening splits from a floating window with the "Open in split" option, this will set the split to open vertically.
configure with: