feat(lsp): join multiple visually selected lines (RustLsp joinLines)

[mrcjkb]

Closes #335

[github-actions]

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

• For example, fix(lsp): some lsp-related bugfix

• Pull request title has the appropriate conventional commit prefix.

If applicable:

• Tested
  • Tests have been added.
  • Tested manually (Steps to reproduce in PR description).
• Updated documentation.
• Updated CHANGELOG.md

[9mm]

    if true {
        dbg!(println!("Hello, world!"));
    }
    if false {
        println!("Hello, world!");
    }

Am i doing something wrong? If i visually select the first 3 lines with <S-V> and join lines I get:

    if true { dbg!(println!("Hello, world!")); } else if false {
        println!("Hello, world!");
    }

[9mm]

It seems its counting lines + 1 for the # of lines selected. selecting 2 rows gives expected result of selecting 3 rows

[mrcjkb]

It seems its counting lines + 1 for the # of lines selected. selecting 2 rows gives expected result of selecting 3 rows

I guess that's an implementation detail of rust-analyzer?
rustaceanvim just sends it the selected range and performs the text edit that rust-analyzer tells it to.

Does it behave differently in vscode?

[9mm]

im not sure i dont use vscode. its not a dealbreaker i guess, but definitely is weird

[9mm]

thank you for adding it though!

[mrcjkb]

Based on the gif in the rust-analyzer docs, it looks like that is the way it behaves (it's also joining the unselected whitespace line).
I guess it's because selecting a single line results in the line below being joined, so it's consistent with that?
But I agree, it's not very intuitive.