-
-
Notifications
You must be signed in to change notification settings - Fork 113
feat(config): apply float_win_config to floating windows #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😄
I don't think it makes sense to reuse the tools.hover_actions config, as the name of the field would be inconsistent.
Instead, I would suggest the following:
- Use a
tools.float_win_configoption, which we apply to all floating windows created by this plugin:
---@field float_win_config table Options applied to floating windows. See |api-win_config|.To keep backward compatibility, we would have to use the tools.hover_actions options if they exist. But we can remove them from the docs in config/init.lua.
For this, we would also have to update config validations, and add a changelog entry (## [Unreleased], ### Added section).
|
Got it. |
…` for replace 'tools.hover_actions'
46de98c to
39d4a4b
Compare
By utilizing the existing optionscan avoid user modifying their config.I think it would be better to do it this way.