Skip to content

Conversation

@saying121
Copy link
Contributor

By utilizing the existing optionscan avoid user modifying their config.I think it would be better to do it this way.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

I don't think it makes sense to reuse the tools.hover_actions config, as the name of the field would be inconsistent.

Instead, I would suggest the following:

  • Use a tools.float_win_config option, which we apply to all floating windows created by this plugin:
---@field float_win_config table Options applied to floating windows. See |api-win_config|.

To keep backward compatibility, we would have to use the tools.hover_actions options if they exist. But we can remove them from the docs in config/init.lua.

For this, we would also have to update config validations, and add a changelog entry (## [Unreleased], ### Added section).

@saying121
Copy link
Contributor Author

Got it.

@saying121 saying121 changed the title feat(config): explain_error window use hover_action config feat(config): apply float_win_config to floating windows Jan 8, 2024
mrcjkb
mrcjkb previously approved these changes Jan 8, 2024
@mrcjkb mrcjkb enabled auto-merge (squash) January 8, 2024 14:29
@mrcjkb mrcjkb disabled auto-merge January 8, 2024 14:29
@mrcjkb mrcjkb enabled auto-merge (squash) January 8, 2024 14:29
@mrcjkb mrcjkb disabled auto-merge January 8, 2024 14:44
@mrcjkb mrcjkb merged commit 07f2984 into mrcjkb:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants