Skip to content

Commit ddf6777

Browse files
Remove warning about inferring packages URI from dart2js
Change-Id: I37ee171b0359e1fa6720d7af9e403f4dfab76e9e Reviewed-on: https://dart-review.googlesource.com/c/79480 Auto-Submit: Peter von der Ahé <[email protected]> Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 1811071 commit ddf6777

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

pkg/compiler/lib/src/dart2js.dart

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ library dart2js.cmdline;
77
import 'dart:async' show Future;
88
import 'dart:convert' show utf8, LineSplitter;
99
import 'dart:io' show exit, File, FileMode, Platform, stdin, stderr;
10+
import 'dart:isolate' show Isolate;
1011

1112
import 'package:front_end/src/api_unstable/dart2js.dart' as fe;
1213
import 'package:package_config/discovery.dart' show findPackages;
@@ -20,7 +21,7 @@ import 'util/command_line.dart';
2021
import 'util/uri_extras.dart';
2122
import 'util/util.dart' show stackTraceFilePrefix;
2223

23-
const String LIBRARY_ROOT = '../../../../../sdk';
24+
const String LIBRARY_ROOT = '../../../../sdk';
2425
const String OUTPUT_LANGUAGE_DART = 'Dart';
2526

2627
/**
@@ -561,9 +562,13 @@ void fail(String message) {
561562
}
562563

563564
Future<api.CompilationResult> compilerMain(List<String> arguments,
564-
{fe.InitializedCompilerState kernelInitializedCompilerState}) {
565-
var root = uriPathToNative("/$LIBRARY_ROOT");
566-
arguments = <String>['--library-root=${Platform.script.toFilePath()}$root']
565+
{fe.InitializedCompilerState kernelInitializedCompilerState}) async {
566+
Uri script = Platform.script;
567+
if (script.isScheme("package")) {
568+
script = await Isolate.resolvePackageUri(script);
569+
}
570+
Uri libraryRoot = script.resolve(LIBRARY_ROOT);
571+
arguments = <String>['--library-root=${libraryRoot.toFilePath()}']
567572
..addAll(arguments);
568573
return compile(arguments,
569574
kernelInitializedCompilerState: kernelInitializedCompilerState);

sdk/bin/dart2js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ fi
5050

5151
DART_ROOT="$(cd "${SDK_DIR}/.." ; pwd -P)"
5252

53-
DART2JS="$DART_ROOT/pkg/compiler/lib/src/dart2js.dart"
53+
DART2JS="package:compiler/src/dart2js.dart"
5454

5555
exec "$DART" "--packages=$DART_ROOT/.packages" "${EXTRA_VM_OPTIONS[@]}" "$DART2JS" "${EXTRA_OPTIONS[@]}" "$@"

0 commit comments

Comments
 (0)