Skip to content

Commit 33d9594

Browse files
authored
Test Python 3.7 with a poetry that supports it (#21)
* Test Python 3.7 with a poetry that supports it Poetry [dropped support for Python 3.7](python-poetry/poetry#7674) in [version 1.6.0](https://python-poetry.org/history/#160---2023-08-20). There's no reason why this plugin cannot work in a python 3.7 environment, provided a poetry that supports that environment is installed. Since poetry 1.5.1 was the last version to support Python 3.7 this change switches the test setup to use poetry 1.5.1 in the case of the Python 3.7 branch of the testing matrix. * Clarify the specifics of Python 3.7 support
1 parent 53d37b3 commit 33d9594

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,12 @@ jobs:
3434
run: echo ::set-output name=version::$(python -c "import sys; print('-'.join(str(v) for v in sys.version_info))")
3535

3636
- name: Install poetry
37-
run: curl -sL curl -sL https://install.python-poetry.org | python - -y
37+
run: |
38+
if [[ "${{ matrix.python-version }}" == "3.7" ]]; then
39+
curl -sSL https://install.python-poetry.org | python - --version 1.5.1 -y
40+
else
41+
curl -sSL https://install.python-poetry.org | python - -y
42+
fi
3843
3944
- name: Update PATH
4045
run: echo "$HOME/.local/bin" >> $GITHUB_PATH

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
A [Poetry](https://python-poetry.org/) plugin that automatically loads environment variables from `.env` files into the environment before poetry commands are run.
66

7-
Supports Python 3.7+
7+
Supports Python 3.7+[^1]
88

99
```sh
1010
$ cat .env
@@ -37,6 +37,7 @@ PIPENV_DONT_LOAD_ENV | POETRY_DONT_LOAD_ENV
3737

3838
### Overriding existing environment variables
3939

40-
By default, this plugin will override existing environment variables. This is because this plugin was built to make onboarding for users coming from `pipenv` as seamless as possible. If you want to prevent existing environment variables from being overridden, you can set the `POETRY_DOTENV_DONT_OVERRIDE` environment variable to `true`.[^1]
40+
By default, this plugin will override existing environment variables. This is because this plugin was built to make onboarding for users coming from `pipenv` as seamless as possible. If you want to prevent existing environment variables from being overridden, you can set the `POETRY_DOTENV_DONT_OVERRIDE` environment variable to `true`.[^2]
4141

42-
[^1]: See [#16](https://github.com/mpeteuil/poetry-dotenv-plugin/pull/16) for background.
42+
[^1]: Python 3.7 is supported only when using Poetry < [1.6.0](https://python-poetry.org/history/#160---2023-08-20), which [dropped support for Python 3.7](https://github.com/python-poetry/poetry/pull/7674).
43+
[^2]: See [#16](https://github.com/mpeteuil/poetry-dotenv-plugin/pull/16) for background.

0 commit comments

Comments
 (0)