Skip to content

Commit 5b58168

Browse files
ShivangiKakkarjonathanKingston
authored andcommitted
Refactored the logic to form warning message
1 parent 4ed453d commit 5b58168

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

src/js/popup.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,15 +1082,12 @@ Logic.registerPanel(P_CONTAINER_DELETE, {
10821082
document.getElementById("delete-container-name").textContent = identity.name;
10831083

10841084
const totalNumberOfTabs = identity.numberOfHiddenTabs + identity.numberOfOpenTabs;
1085+
let warningMessage = "";
10851086
if (totalNumberOfTabs > 0) {
1086-
let warningMessage = `If you remove this container now, ${totalNumberOfTabs} `;
1087-
warningMessage += totalNumberOfTabs > 1
1088-
? "container tabs will be closed."
1089-
: "container tab will be closed.";
1090-
document.getElementById("delete-container-tab-warning").textContent = warningMessage;
1091-
} else {
1092-
document.getElementById("delete-container-tab-warning").textContent = "";
1087+
const grammaticalNumTabs = totalNumberOfTabs > 1 ? "tabs" : "tab";
1088+
warningMessage = `If you remove this container now, ${totalNumberOfTabs} container ${grammaticalNumTabs} will be closed.`;
10931089
}
1090+
document.getElementById("delete-container-tab-warning").textContent = warningMessage;
10941091

10951092
const icon = document.getElementById("delete-container-icon");
10961093
icon.setAttribute("data-identity-icon", identity.icon);

0 commit comments

Comments
 (0)