Bug 1320977 - Add review/feedback/needinfo request counts and block statuses to /rest/user and /rest/user/suggest responses

[kyoshino]

Fix Bug 1320977 - Add review/feedback/needinfo request counts and block statuses to /rest/user and /rest/user/suggest responses

Example

/rest/user/suggest will look like this:

{
   "users" : [
      {
         "id" : 1,
         "name" : "[email protected]",
         "real_name" : "Vagrant Nakamoto",
         "requests" : {
            "feedback" : {
               "blocked" : false,
               "pending" : 0
            },
            "needinfo" : {
               "blocked" : true,
               "pending" : 0
            },
            "review" : {
               "blocked" : false,
               "pending" : 1
            }
         }
      }
   ]
}

[kyoshino]

Not sure if this makes /rest/user/suggest a bit slow. @dylanwh is this okay for you? We have to add request statuses to API responses anyway.

[dylanwh]

I'll do some benchmarks. I think we can avoid using $webservice->type() for some speed gains.
The only downside is XMLRPC won't work but we don't care about that.

For $webservice->type('boolean', $val) do $val ? JSON::MaybeXS->true : JSON::MaybeXS->false
For $webservice->type('int', $val) do int($val)

[dylanwh]

This would have added 8ms:

spent 8.16ms (158µs+8.00) within Bugzilla::Extension::Review::webservice_user_get

But I made it better:

spent 3.87ms (127µs+3.74) within Bugzilla::Extension::Review::webservice_user_get

I'll post those changes shortly.

[dylanwh]

I'll approve this and make another PR for making it faster.