Decimal #58
Merged
Decimal #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I introduced the precision, the maxYLabelWith is not the width of the raw value but the width of the formatted one. As the computing the of maxYLabelWidth is done in calc(), I moved yInterval in it because I need it to compute the precision. Also I think it makes more sense, because the calc() method is supposed to "do any size-related calculations".
In order to let the user to get rid of the precision, she can provide a custom yLabelFormat funciton.
Contributor
|
Merged at last - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the support for decimal values in the y axis (useful when you only plot data between 0 and 1).