Allow configuration of worst case buy execution weight (paritytech#7944)

girazoki · bkontur · acatangiu · RomarQ · commit 78897f9618a6 · 2025-08-29T16:37:34.000+01:00
Adds `worst_case_buy_execution` to the Config trait of `pallet-xcm-benchmarks` with a default implementation that mimics the code that existed previous to this PR. Rationale: not allowing to set the `WeightLimit` and the `FeeAsset` might mean that we dont benchmark the worst case, as with `WeightLimit::Unlimited` the `Trader` does not even execute: https://github.com/paritytech/polkadot-sdk/blob/c01dbebeaa6394691974de46dd2d41a582f6a4c2/polkadot/xcm/xcm-executor/src/lib.rs#L833 The new configurable function allows projects to customize the parameters with which the benchmark is run to make sure they account for the worst-case scenario **This is very likely the case of the assethub system chain**, with several traders being analyzed and possibly several reads being made: https://github.com/paritytech/polkadot-sdk/blob/38d2fa859861005157ccb249dca1378f015e0b06/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs#L403 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
diff --git a/bridges/chains/chain-bridge-hub-westend/src/lib.rs b/bridges/chains/chain-bridge-hub-westend/src/lib.rs
@@ -94,7 +94,7 @@ frame_support::parameter_types! {
 	/// The XCM fee that is paid for executing XCM program (with `ExportMessage` instruction) at the Westend
 	/// BridgeHub.
 	/// (initially was calculated by test `BridgeHubWestend::can_calculate_weight_for_paid_export_message_with_reserve_transfer` + `33%`)
-	pub const BridgeHubWestendBaseXcmFeeInWnds: u128 = 18_191_740_000;
+	pub const BridgeHubWestendBaseXcmFeeInWnds: u128 = 22_962_450_000;
 
 	/// Transaction fee that is paid at the Westend BridgeHub for delivering single inbound message.
 	/// (initially was calculated by test `BridgeHubWestend::can_calculate_fee_for_standalone_message_delivery_transaction` + `33%`)
diff --git a/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs
@@ -101,7 +101,7 @@ use polkadot_runtime_common::{BlockHashCount, SlowAdjustingFeeUpdate};
 #[cfg(feature = "runtime-benchmarks")]
 use xcm::latest::prelude::{
 	Asset, Assets as XcmAssets, Fungible, Here, InteriorLocation, Junction, Junction::*, Location,
-	NetworkId, NonFungible, Parent, ParentThen, Response, XCM_VERSION,
+	NetworkId, NonFungible, Parent, ParentThen, Response, WeightLimit, XCM_VERSION,
 };
 use xcm::{
 	latest::prelude::{AssetId, BodyId},
@@ -1994,11 +1994,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(TokenLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
@@ -112,7 +112,7 @@ use frame_support::traits::PalletInfoAccess;
 #[cfg(feature = "runtime-benchmarks")]
 use xcm::latest::prelude::{
 	Asset, Assets as XcmAssets, Fungible, Here, InteriorLocation, Junction, Junction::*, Location,
-	NetworkId, NonFungible, Parent, ParentThen, Response, XCM_VERSION,
+	NetworkId, NonFungible, Parent, ParentThen, Response, WeightLimit, XCM_VERSION,
 };
 
 use xcm_runtime_apis::{
@@ -2265,11 +2265,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(WestendLocation::get()),
 						fun: Fungible(1_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
@@ -1253,11 +1253,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(TokenLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs
@@ -1193,11 +1193,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(WestendLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
@@ -1270,7 +1270,11 @@ impl_runtime_apis! {
 				}
 
 				fn alias_origin() -> Result<(Location, Location), BenchmarkError> {
-					Err(BenchmarkError::Skip)
+					// Any location can alias to an internal location.
+					// Here parachain 1000 aliases to an internal account.
+					let origin = Location::new(1, [Parachain(1000)]);
+					let target = Location::new(1, [Parachain(1000), AccountId32 { id: [128u8; 32], network: None }]);
+					Ok((origin, target))
 				}
 			}
 
diff --git a/cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs b/cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs
@@ -1275,11 +1275,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(WndLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs b/cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
@@ -1133,11 +1133,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(RocRelayLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs b/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
@@ -1159,11 +1159,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(TokenRelayLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/people/people-rococo/src/lib.rs b/cumulus/parachains/runtimes/people/people-rococo/src/lib.rs
@@ -1053,11 +1053,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(RelayLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/cumulus/parachains/runtimes/people/people-westend/src/lib.rs b/cumulus/parachains/runtimes/people/people-westend/src/lib.rs
@@ -1070,11 +1070,11 @@ impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(RelayLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/polkadot/runtime/rococo/src/lib.rs b/polkadot/runtime/rococo/src/lib.rs
@@ -2648,11 +2648,11 @@ sp_api::impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(TokenLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/polkadot/runtime/westend/src/lib.rs b/polkadot/runtime/westend/src/lib.rs
@@ -2871,11 +2871,11 @@ sp_api::impl_runtime_apis! {
 					Ok((origin, ticket, assets))
 				}
 
-				fn fee_asset() -> Result<Asset, BenchmarkError> {
-					Ok(Asset {
+				fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+					Ok((Asset {
 						id: AssetId(TokenLocation::get()),
 						fun: Fungible(1_000_000 * UNITS),
-					})
+					}, WeightLimit::Limited(Weight::from_parts(5000, 5000))))
 				}
 
 				fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/polkadot/xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs b/polkadot/xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs
@@ -102,11 +102,13 @@ mod benchmarks {
 		let mut executor = new_executor::<T>(Default::default());
 		executor.set_holding(holding);
 
-		let fee_asset = AssetId(Here.into());
+		// The worst case we want for buy execution in terms of
+		// fee asset and weight
+		let (fee_asset, weight_limit) = T::worst_case_for_trader()?;
 
 		let instruction = Instruction::<XcmCallOf<T>>::BuyExecution {
-			fees: (fee_asset, 100_000_000u128).into(), // should be something inside of holding
-			weight_limit: WeightLimit::Unlimited,
+			fees: fee_asset,
+			weight_limit: weight_limit.into(),
 		};
 
 		let xcm = Xcm(vec![instruction]);
@@ -127,7 +129,7 @@ mod benchmarks {
 		// Set some weight to be paid for.
 		executor.set_message_weight(Weight::from_parts(100_000_000, 100_000));
 
-		let fee_asset: Asset = T::fee_asset().unwrap();
+		let (fee_asset, _): (Asset, WeightLimit) = T::worst_case_for_trader().unwrap();
 
 		let instruction = Instruction::<XcmCallOf<T>>::PayFees { asset: fee_asset };
 
@@ -207,7 +209,8 @@ mod benchmarks {
 		let mut executor = new_executor::<T>(Default::default());
 		let holding_assets = T::worst_case_holding(1);
 		// We can already buy execution since we'll load the holding register manually
-		let asset_for_fees = T::fee_asset().unwrap();
+		let (asset_for_fees, _): (Asset, WeightLimit) = T::worst_case_for_trader().unwrap();
+
 		let previous_xcm = Xcm(vec![BuyExecution {
 			fees: asset_for_fees,
 			weight_limit: Limited(Weight::from_parts(1337, 1337)),
diff --git a/polkadot/xcm/pallet-xcm-benchmarks/src/generic/mock.rs b/polkadot/xcm/pallet-xcm-benchmarks/src/generic/mock.rs
@@ -173,8 +173,8 @@ impl generic::Config for Test {
 		Ok((Default::default(), ticket, assets))
 	}
 
-	fn fee_asset() -> Result<Asset, BenchmarkError> {
-		Ok(Asset { id: AssetId(Here.into()), fun: Fungible(1_000_000) })
+	fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {
+		Ok((Asset { id: AssetId(Here.into()), fun: Fungible(1_000_000) }, WeightLimit::Unlimited))
 	}
 
 	fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {
diff --git a/polkadot/xcm/pallet-xcm-benchmarks/src/generic/mod.rs b/polkadot/xcm/pallet-xcm-benchmarks/src/generic/mod.rs
@@ -26,7 +26,9 @@ pub mod pallet {
 	use frame_benchmarking::BenchmarkError;
 	use frame_support::{dispatch::GetDispatchInfo, pallet_prelude::Encode};
 	use sp_runtime::traits::Dispatchable;
-	use xcm::latest::{Asset, Assets, InteriorLocation, Junction, Location, NetworkId, Response};
+	use xcm::latest::{
+		Asset, Assets, InteriorLocation, Junction, Location, NetworkId, Response, WeightLimit,
+	};
 
 	#[pallet::config]
 	pub trait Config<I: 'static = ()>: frame_system::Config + crate::Config {
@@ -73,9 +75,11 @@ pub mod pallet {
 		/// Return an origin, ticket, and assets that can be trapped and claimed.
 		fn claimable_asset() -> Result<(Location, Location, Assets), BenchmarkError>;
 
-		/// Asset used to pay for fees. Used to buy weight in benchmarks, for example in
+		/// The worst case buy execution weight limit and
+		/// asset to trigger the Trader::buy_execution in the XCM executor
+		/// Used to buy weight in benchmarks, for example in
 		/// `refund_surplus`.
-		fn fee_asset() -> Result<Asset, BenchmarkError>;
+		fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError>;
 
 		/// Return an unlocker, owner and assets that can be locked and unlocked.
 		fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError>;
diff --git a/prdoc/pr_7944.prdoc b/prdoc/pr_7944.prdoc
@@ -0,0 +1,43 @@
+title: Allow to set a worst case buy execution fee asset and weight
+doc:
+- audience: Runtime Dev
+  description: |-
+    Allows to set a worst case for the `BuyExecution` XCM instruction
+    benchmark. Currently the benchmark assumes best case scenario (i.e.)
+    the case where does not even need to go into the Trader. This PR allows
+    developers to set the worst-case scenario as they wish.
+    
+    Breaking changes:
+      - Change `fee_asset` in the benchmarking helper to `worst_case_for_trader` which
+        now should return both the `fee_asset` and the weight to use
+crates:
+  - name: pallet-xcm-benchmarks
+    bump: major
+  - name: rococo-runtime
+    bump: patch
+  - name: westend-runtime
+    bump: patch
+  - name: asset-hub-rococo-runtime
+    bump: patch
+  - name: asset-hub-westend-runtime
+    bump: patch
+  - name: bridge-hub-rococo-runtime
+    bump: patch
+  - name: bridge-hub-westend-runtime
+    bump: patch
+  - name: collectives-westend-runtime
+    bump: patch
+  - name: coretime-rococo-runtime
+    bump: patch
+  - name: coretime-westend-runtime
+    bump: patch
+  - name: people-rococo-runtime
+    bump: patch
+  - name: people-westend-runtime
+    bump: patch
+  - name: bp-bridge-hub-westend    
+    bump: patch
+  - name: pallet-staking-async-parachain-runtime    
+    bump: patch
+  - name: pallet-staking-async-rc-runtime    
+    bump: patch

Original file line number	Diff line number	Diff line change
`@@ -1253,11 +1253,11 @@ impl_runtime_apis! {`
`1253`	`1253`	`Ok((origin, ticket, assets))`
`1254`	`1254`	`}`
`1255`	`1255`
`1256`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1257`		`- Ok(Asset {`
	`1256`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1257`	`+ Ok((Asset {`
`1258`	`1258`	`id: AssetId(TokenLocation::get()),`
`1259`	`1259`	`fun: Fungible(1_000_000 * UNITS),`
`1260`		`- })`
	`1260`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1261`	`1261`	`}`
`1262`	`1262`
`1263`	`1263`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
Original file line number	Diff line number	Diff line change
`@@ -1193,11 +1193,11 @@ impl_runtime_apis! {`
`1193`	`1193`	`Ok((origin, ticket, assets))`
`1194`	`1194`	`}`
`1195`	`1195`
`1196`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1197`		`- Ok(Asset {`
	`1196`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1197`	`+ Ok((Asset {`
`1198`	`1198`	`id: AssetId(WestendLocation::get()),`
`1199`	`1199`	`fun: Fungible(1_000_000 * UNITS),`
`1200`		`- })`
	`1200`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1201`	`1201`	`}`
`1202`	`1202`
`1203`	`1203`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
`@@ -1270,7 +1270,11 @@ impl_runtime_apis! {`
`1270`	`1270`	`}`
`1271`	`1271`
`1272`	`1272`	`fn alias_origin() -> Result<(Location, Location), BenchmarkError> {`
`1273`		`- Err(BenchmarkError::Skip)`
	`1273`	`+ // Any location can alias to an internal location.`
	`1274`	`+ // Here parachain 1000 aliases to an internal account.`
	`1275`	`+ let origin = Location::new(1, [Parachain(1000)]);`
	`1276`	`+ let target = Location::new(1, [Parachain(1000), AccountId32 { id: [128u8; 32], network: None }]);`
	`1277`	`+ Ok((origin, target))`
`1274`	`1278`	`}`
`1275`	`1279`	`}`
`1276`	`1280`
Original file line number	Diff line number	Diff line change
`@@ -1275,11 +1275,11 @@ impl_runtime_apis! {`
`1275`	`1275`	`Ok((origin, ticket, assets))`
`1276`	`1276`	`}`
`1277`	`1277`
`1278`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1279`		`- Ok(Asset {`
	`1278`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1279`	`+ Ok((Asset {`
`1280`	`1280`	`id: AssetId(WndLocation::get()),`
`1281`	`1281`	`fun: Fungible(1_000_000 * UNITS),`
`1282`		`- })`
	`1282`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1283`	`1283`	`}`
`1284`	`1284`
`1285`	`1285`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
Original file line number	Diff line number	Diff line change
`@@ -1133,11 +1133,11 @@ impl_runtime_apis! {`
`1133`	`1133`	`Ok((origin, ticket, assets))`
`1134`	`1134`	`}`
`1135`	`1135`
`1136`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1137`		`- Ok(Asset {`
	`1136`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1137`	`+ Ok((Asset {`
`1138`	`1138`	`id: AssetId(RocRelayLocation::get()),`
`1139`	`1139`	`fun: Fungible(1_000_000 * UNITS),`
`1140`		`- })`
	`1140`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1141`	`1141`	`}`
`1142`	`1142`
`1143`	`1143`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
Original file line number	Diff line number	Diff line change
`@@ -1159,11 +1159,11 @@ impl_runtime_apis! {`
`1159`	`1159`	`Ok((origin, ticket, assets))`
`1160`	`1160`	`}`
`1161`	`1161`
`1162`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1163`		`- Ok(Asset {`
	`1162`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1163`	`+ Ok((Asset {`
`1164`	`1164`	`id: AssetId(TokenRelayLocation::get()),`
`1165`	`1165`	`fun: Fungible(1_000_000 * UNITS),`
`1166`		`- })`
	`1166`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1167`	`1167`	`}`
`1168`	`1168`
`1169`	`1169`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
Original file line number	Diff line number	Diff line change
`@@ -1053,11 +1053,11 @@ impl_runtime_apis! {`
`1053`	`1053`	`Ok((origin, ticket, assets))`
`1054`	`1054`	`}`
`1055`	`1055`
`1056`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1057`		`- Ok(Asset {`
	`1056`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1057`	`+ Ok((Asset {`
`1058`	`1058`	`id: AssetId(RelayLocation::get()),`
`1059`	`1059`	`fun: Fungible(1_000_000 * UNITS),`
`1060`		`- })`
	`1060`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1061`	`1061`	`}`
`1062`	`1062`
`1063`	`1063`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`
Original file line number	Diff line number	Diff line change
`@@ -1070,11 +1070,11 @@ impl_runtime_apis! {`
`1070`	`1070`	`Ok((origin, ticket, assets))`
`1071`	`1071`	`}`
`1072`	`1072`
`1073`		`- fn fee_asset() -> Result<Asset, BenchmarkError> {`
`1074`		`- Ok(Asset {`
	`1073`	`+ fn worst_case_for_trader() -> Result<(Asset, WeightLimit), BenchmarkError> {`
	`1074`	`+ Ok((Asset {`
`1075`	`1075`	`id: AssetId(RelayLocation::get()),`
`1076`	`1076`	`fun: Fungible(1_000_000 * UNITS),`
`1077`		`- })`
	`1077`	`+ }, WeightLimit::Limited(Weight::from_parts(5000, 5000))))`
`1078`	`1078`	`}`
`1079`	`1079`
`1080`	`1080`	`fn unlockable_asset() -> Result<(Location, Location, Asset), BenchmarkError> {`