From 531770558e0ad79cb908b6c1df4c53f0133e0173 Mon Sep 17 00:00:00 2001 From: Mario J Maurello Date: Mon, 28 Aug 2023 17:38:46 +0200 Subject: [PATCH 1/5] add destinationFeeBalance property in the response examples --- .../interoperability/xcm/xcm-sdk/v1/xcm-sdk.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md b/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md index 2999b1456..c25cfcb7a 100644 --- a/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md +++ b/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md @@ -329,6 +329,13 @@ As previously mentioned, regardless of which method you use to build the transfe weight: 1000000000, ws: 'wss://rpc.polkadot.io' }, + destinationFeeBalance: e { + key: 'dot', + originSymbol: 'DOT', + amount: 0n, + decimals: 10, + symbol: 'DOT' + }, existentialDeposit: e { key: 'dot', originSymbol: 'DOT', @@ -438,6 +445,13 @@ The `swap` function returns the transfer data with the original source chain and weight: 1000000000, ws: 'wss://rpc.polkadot.io' }, + destinationFeeBalance: e { + key: 'dot', + originSymbol: 'DOT', + amount: 0n, + decimals: 10, + symbol: 'DOT' + }, existentialDeposit: e { key: 'dot', originSymbol: 'DOT', From d497042be00bb62f0d2da366a1f2e16841c121cc Mon Sep 17 00:00:00 2001 From: Erin Shaben Date: Tue, 29 Aug 2023 11:31:48 -0400 Subject: [PATCH 2/5] add destinationFeeBalance to reference page --- .../xcm/xcm-sdk/v1/reference.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/builders/interoperability/xcm/xcm-sdk/v1/reference.md b/builders/interoperability/xcm/xcm-sdk/v1/reference.md index e59d6b806..277d1f80a 100644 --- a/builders/interoperability/xcm/xcm-sdk/v1/reference.md +++ b/builders/interoperability/xcm/xcm-sdk/v1/reference.md @@ -110,15 +110,16 @@ The XCM SDK is based on the premise of defining an asset to transfer and then de - `SourceChainTransferData` - defines the source chain data for the transfer - | Name | Type | Description | - |:--------------------:|:-------------:|:------------------------------------------------------------------------------------------------------------------------------------------------------:| - | `balance` | *AssetAmount* | The balance of the asset being transferred for the source address | - | `chain` | *AnyChain* | The source chain information | - | `existentialDeposit` | *AssetAmount* | The existential deposit for the asset being transferred on the source chain | - | `fee` | *AssetAmount* | The amount of fees for the asset being transferred on the source chain | - | `feeBalance` | *AssetAmount* | The balance of the asset being transferred on the source chain | - | `min` | *AssetAmount* | The minimum amount of the asset that should be kept on the source chain, taking into consideration the `existentialDeposit` and `fee` for the transfer | - | `max` | *AssetAmount* | The maximum amount of the asset that *can* be transferred | + | Name | Type | Description | + |:-----------------------:|:-------------:|:------------------------------------------------------------------------------------------------------------------------------------------------------:| + | `balance` | *AssetAmount* | The balance of the asset being transferred for the source address | + | `chain` | *AnyChain* | The source chain information | + | `destinationFeeBalance` | *AssetAmount* | The balance of the asset used to pay for fees in the desintation chain | + | `existentialDeposit` | *AssetAmount* | The existential deposit for the asset being transferred on the source chain | + | `fee` | *AssetAmount* | The amount of fees for the asset being transferred on the source chain | + | `feeBalance` | *AssetAmount* | The balance of the asset being transferred on the source chain | + | `min` | *AssetAmount* | The minimum amount of the asset that should be kept on the source chain, taking into consideration the `existentialDeposit` and `fee` for the transfer | + | `max` | *AssetAmount* | The maximum amount of the asset that *can* be transferred | ## Core Methods {: #core-sdk-methods } From cf4a0508c3e1d0d5a81923193f03bd02149e8cc1 Mon Sep 17 00:00:00 2001 From: Erin Shaben Date: Tue, 29 Aug 2023 11:32:40 -0400 Subject: [PATCH 3/5] destinationFeeBalance is part of the source chain object --- .../interoperability/xcm/xcm-sdk/v1/xcm-sdk.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md b/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md index c25cfcb7a..97039bcb7 100644 --- a/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md +++ b/builders/interoperability/xcm/xcm-sdk/v1/xcm-sdk.md @@ -445,13 +445,6 @@ The `swap` function returns the transfer data with the original source chain and weight: 1000000000, ws: 'wss://rpc.polkadot.io' }, - destinationFeeBalance: e { - key: 'dot', - originSymbol: 'DOT', - amount: 0n, - decimals: 10, - symbol: 'DOT' - }, existentialDeposit: e { key: 'dot', originSymbol: 'DOT', @@ -527,6 +520,13 @@ The `swap` function returns the transfer data with the original source chain and id: 1284, rpc: 'https://rpc.api.moonbeam.network' }, + destinationFeeBalance: e { + key: 'dot', + originSymbol: 'DOT', + amount: 0n, + decimals: 10, + symbol: 'DOT' + }, existentialDeposit: e { key: 'glmr', originSymbol: 'GLMR', From 6cb2c0840cd9d9e031e410cdfb91e9a17c41228d Mon Sep 17 00:00:00 2001 From: Erin Shaben Date: Fri, 1 Sep 2023 12:09:06 -0400 Subject: [PATCH 4/5] Update builders/interoperability/xcm/xcm-sdk/v1/reference.md Co-authored-by: Kevin Neilson --- builders/interoperability/xcm/xcm-sdk/v1/reference.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builders/interoperability/xcm/xcm-sdk/v1/reference.md b/builders/interoperability/xcm/xcm-sdk/v1/reference.md index 277d1f80a..7e5c5d64b 100644 --- a/builders/interoperability/xcm/xcm-sdk/v1/reference.md +++ b/builders/interoperability/xcm/xcm-sdk/v1/reference.md @@ -114,7 +114,7 @@ The XCM SDK is based on the premise of defining an asset to transfer and then de |:-----------------------:|:-------------:|:------------------------------------------------------------------------------------------------------------------------------------------------------:| | `balance` | *AssetAmount* | The balance of the asset being transferred for the source address | | `chain` | *AnyChain* | The source chain information | - | `destinationFeeBalance` | *AssetAmount* | The balance of the asset used to pay for fees in the desintation chain | + | `destinationFeeBalance` | *AssetAmount* | The balance of the asset used to pay for fees in the destination chain | | `existentialDeposit` | *AssetAmount* | The existential deposit for the asset being transferred on the source chain | | `fee` | *AssetAmount* | The amount of fees for the asset being transferred on the source chain | | `feeBalance` | *AssetAmount* | The balance of the asset being transferred on the source chain | From d0c42fbad94fc8eb536b0c1f033dc283e94f3724 Mon Sep 17 00:00:00 2001 From: Erin Shaben Date: Fri, 1 Sep 2023 12:11:18 -0400 Subject: [PATCH 5/5] fix typo --- builders/interoperability/xcm/xcm-sdk/v1/reference.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builders/interoperability/xcm/xcm-sdk/v1/reference.md b/builders/interoperability/xcm/xcm-sdk/v1/reference.md index 7e5c5d64b..bf43e416a 100644 --- a/builders/interoperability/xcm/xcm-sdk/v1/reference.md +++ b/builders/interoperability/xcm/xcm-sdk/v1/reference.md @@ -220,7 +220,7 @@ When building transfer data with the `Sdk().assets()` function, you'll use multi |:----------:|:--------:|:---------------------------------------------------------------------------------------------:| | `accounts` | function | Sets the source address, the destination address, and the signer(s) required for the transfer | -- `accounts()` - sets the source address, the destination address, and the signer(s) required for the transfer. **Must call `destionation()` first** +- `accounts()` - sets the source address, the destination address, and the signer(s) required for the transfer. **Must call `destination()` first** ??? code "Parameters" | Name | Type | Description |